Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore an Objective-C exception #24250

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Ignore an Objective-C exception #24250

wants to merge 1 commit into from

Conversation

crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Mar 18, 2025

Fixes #24247.

See the inline code comment for details.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.9 milestone Mar 18, 2025
@crazytonyli crazytonyli requested review from pmusolino and kean March 18, 2025 22:47
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.9. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24250-9e6918d
Version25.8
Bundle IDorg.wordpress.alpha
Commit9e6918d
App Center BuildWPiOS - One-Offs #11716
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24250-9e6918d
Version25.8
Bundle IDcom.jetpack.alpha
Commit9e6918d
App Center Buildjetpack-installable-builds #10745
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright!

Sorry it took me a while to review this, but I wanted to verify it locally (just in case!) using the steps from #24247

All good!

Approving to unblock, my question regarding the scope to which we should wrap possible exceptions is not a blocker at all.

try? WPException.objcTry {
self.mySiteViewController = self.makeMySiteViewController()
self.navigationController.viewControllers = [self.rootContentViewController]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we consider safe to blanket ignore any exception here because we are confident they would arise only when running unit tests due to the many stateful assumption in the app at the moment.

Is that safe?

How would you feel about running this only if NSClassFromString("XCTestCase") != nil?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WordPressDotComAuthenticatorTests crashes when you disable StatsWidgetsStoreTests
5 participants