Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21473: Do not show the login screen if the user is already logged in #24241

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

crazytonyli
Copy link
Contributor

Fixes #21473

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.9 milestone Mar 17, 2025
@crazytonyli crazytonyli requested review from pmusolino and kean March 17, 2025 23:22
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.9. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24241-cca105f
Version25.8
Bundle IDcom.jetpack.alpha
Commitcca105f
App Center Buildjetpack-installable-builds #10734
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24241-cca105f
Version25.8
Bundle IDorg.wordpress.alpha
Commitcca105f
App Center BuildWPiOS - One-Offs #11705
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Member

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crazytonyli for fixing this.

Everything works as expected 👍

However, I am encountering a problem not strictly related to this issue, namely that when I delete the website, the deletion view remains open, while below there is the view to add a new website. It is not blocking, because clicking outside the view dismisses it, however, the UX needs to be improved. Opened an issue here.

@crazytonyli
Copy link
Contributor Author

@pmusolino Good catch! I can look into the issue later.

@crazytonyli crazytonyli added this pull request to the merge queue Mar 18, 2025
Merged via the queue into trunk with commit fed3be5 Mar 18, 2025
27 checks passed
@crazytonyli crazytonyli deleted the bugfix/issue-21473 branch March 18, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes on iPad after deleting the last site
5 participants