Move WPAccount wordPressComRestAPI definition to Swift
#24230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24230-50f3d06 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 50f3d06 | |
| App Center Build | WPiOS - One-Offs #11725 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24230-50f3d06 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 50f3d06 | |
| App Center Build | jetpack-installable-builds #10753 |
kean
approved these changes
Mar 17, 2025
| get { | ||
| if let api = objc_getAssociatedObject(self, &apiAssociatedKey) as? WordPressComRestApi { | ||
| return api | ||
| } else { |
There was a problem hiding this comment.
(nit) I'd suggest removing the else to reduce the indenting a bit.
| if let api = objc_getAssociatedObject(self, &apiAssociatedKey) as? WordPressComRestApi { | ||
| return api | ||
| } else { | ||
| if authToken.isEmpty { |
There was a problem hiding this comment.
(nit) seems like a good place for a guard
There was a problem hiding this comment.
Thanks for both guard suggestions!
Finally got to address them in 50f3d06
mokagio
force-pushed
the
mokagio/decouple-wpaccount-rest-api
branch
from
1755968 to
50f3d06
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24165.
Following up on a suggestion by @kean internally, ref p1741953158905339-slack-C08HQR4C2TS, this PR splits the definition of the
wordPressComRestAPIproperty inWPAccountfrom its implementation between the Objective-C and Swift layer in an attempt to allow movingWPAccountaway from the app target(s) and into WordPressData.The unit tests are green, which is encouraging.
I also tested this on device via Jetpack.