Move pushNotificationAppID to BuildSettings

[kean]

Changes

• Move the settings
• Remove the "internal" variants (org.wordpress.internal) as discussed

To test:

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr24224-b3804b0
	Version	25.8
	Bundle ID	org.wordpress.alpha
	Commit	b3804b0
	App Center Build	WPiOS - One-Offs #11681

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr24224-b3804b0
	Version	25.8
	Bundle ID	com.jetpack.alpha
	Commit	b3804b0
	App Center Build	jetpack-installable-builds #10710

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[mokagio]

Just a note to say I verified the build configuration to identifier relationship for all the entries.

Next, I'll checkout locally and have a look at how they resolve, just in case.

[mokagio]

I run the following test.

Hacked a print for the config and push id:

$ git diff

diff --git a/WordPress/Classes/ViewRelated/Me/App Settings/DebugMenuViewController.swift b/WordPress/Classes/ViewRelated/Me/App Settings/DebugMenuViewController.swift
index 99cbeb3076..103dd255de 100644
--- a/WordPress/Classes/ViewRelated/Me/App Settings/DebugMenuViewController.swift	
+++ b/WordPress/Classes/ViewRelated/Me/App Settings/DebugMenuViewController.swift	
@@ -1,5 +1,6 @@
 import UIKit
 import AutomatticTracks
+import BuildSettingsKit
 import SwiftUI
 import WordPressFlux
 import TipKit
@@ -9,6 +10,16 @@ struct DebugMenuView: View {
 
     fileprivate var navigation: NavigationContext
 
+    private var name: String {
+#if DEBUG
+        "Debug"
+#elseif ALPHA_BUILD
+        "Alpha"
+#else
+        "Release"
+#endif
+    }
+
     var body: some View {
         List {
             Section { main }
@@ -17,6 +28,9 @@ struct DebugMenuView: View {
                 Section(Strings.sectionTipKit) { tipKit }
             }
             Section(Strings.sectionLogging) { logging }
+            Section("Push info") {
+                Text("On \(name) build with PushNotificationAppID: \(BuildSettings.pushNotificationAppID)")
+            }
         }
         .toolbar {
             ToolbarItem(placement: .principal) {
diff --git a/WordPress/WordPress.xcodeproj/xcshareddata/xcschemes/Jetpack.xcscheme b/WordPress/WordPress.xcodeproj/xcshareddata/xcschemes/Jetpack.xcscheme
index 5e3b091eb1..6b60b8d45e 100644
--- a/WordPress/WordPress.xcodeproj/xcshareddata/xcschemes/Jetpack.xcscheme
+++ b/WordPress/WordPress.xcodeproj/xcshareddata/xcschemes/Jetpack.xcscheme
@@ -59,7 +59,7 @@
       </Testables>
    </TestAction>
    <LaunchAction
-      buildConfiguration = "Debug"
+      buildConfiguration = "Release"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       launchStyle = "0"

However, for some reason I can't explain both Release and Release-Alpha builds crash on my device 🤔

I even let CI build the alpha build, but the result was the same.

I really want to get to the bottom of this, but I already spent some time running around in circles. I'm sure it's something dumb that I'm doing that I'll figure out later after taking a step back. I want to move on with the #24165 work.

Approving to unblock.