Offer "Log in with a different account" when OAuth is denied #24215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24215-10dc0cc | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 10dc0cc | |
| App Center Build | WPiOS - One-Offs #11704 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24215-10dc0cc | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 10dc0cc | |
| App Center Build | jetpack-installable-builds #10733 |
|
This is a very clever solution and I like it a lot! I think we could tweak the messaging to be something like """ You can sign in with a different account if you need a different one. Tap "Use Different Account" to start. |
kean
reviewed
Mar 14, 2025
| // Try to re-authenticate when user taps the "Deny" button. | ||
| let reLogin = await withCheckedContinuation { continuation in | ||
| DispatchQueue.main.async { | ||
| let format = NSLocalizedString("wpComLogin.loginDenied.message", value: "You can sign in with a different account if you need a different one. Tap \"%@\" to start.", comment: "Message shown when user denies WordPress.com login, offering option to try with different account") |
There was a problem hiding this comment.
Please extract the localizable strings into Strings, and I'd also extracting the "reLogin" code into a separate method to make it easier to follow the overall flow of the authenticate method.
There was a problem hiding this comment.
👍 Addressed in 10dc0cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #24195 (comment) for context.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-14.at.12.23.00.mp4
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: