Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the "Verify Your Email" view on no sites view #24211

Closed
wants to merge 10 commits into from

Conversation

crazytonyli
Copy link
Contributor

Fixes #24205. See the issue description and comments for details.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-13.at.22.03.57.mp4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 13, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24211-af9c13b
Version25.8
Bundle IDcom.jetpack.alpha
Commitaf9c13b
App Center Buildjetpack-installable-builds #10781
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 13, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24211-af9c13b
Version25.8
Bundle IDorg.wordpress.alpha
Commitaf9c13b
App Center BuildWPiOS - One-Offs #11755
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of nudging customers to verify their email, we can show the "Verify Your Email" view on the newly created account. Since the "Create WordPress.com site" flow is broken, we can disable the button, which echos the description in "Verify Your Email": "Verify your email to [...] access more features".

If verification is required to create a site and there are no other ways to address it, the app should show a "Verify Your Email" step when you tap the "Create WordPress.com Site" button. The new step can be fullscreen like we used to have in WordPressAuthentificator. Showing both the disabled button and the notice sends a confusing message.

@crazytonyli
Copy link
Contributor Author

@kean Good point! Do you think showing the "Verify Your Email" on the "no site view" is still necessary, if we will show it in a modal?

@crazytonyli
Copy link
Contributor Author

Maybe we can keep the UI change in this PR and add a simple alert to ask the user to verify their email?

@crazytonyli crazytonyli requested a review from kean March 20, 2025 09:38
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kean Good point! Do you think showing the "Verify Your Email" on the "no site view" is still necessary, if we will show it in a modal?

I think "Verify Your Email" is not needed and looks off on the "No Sites" view. It's the first thing you will see after creating an account. It sends a confusing message: should I "Create Account" now or "Verify", what do I do first?

User scenarios:

  • If you want to create an account, you'd tap "Create Account" and be prompted to verify.
  • If you want to explore Reader, you don't need to verify account.
  • If you go to Me, you're the the "Verify" prompt

There is no reason for it to exist on the "No Sites View".

"Verify Your Email" (assuming it's not critical to access Reader, update your profile, etc) should be in one place – "Me" tab. If we want to lead users there, there needs to be a badge on the tab bar icon. If "Verify Your Email" is so important, it has to be done as one of the account creation steps.

@crazytonyli
Copy link
Contributor Author

The "Verify your email" banner appears on the user's dashboard (where you see a list of your sites). I thought we should do the same in the app to nudge users to verify their email.

They probably don't need to verify their email, but I think we want them to do that as soon as possible. Many checks in the WordPress.com login process require the user to verify their email, which is the technical reason why we can't get auth cookies using an unverified account token.

We want app users to verify their email even more because some features (post preview, themes, domains, etc) won't work without auth cookies.

@kean
Copy link
Contributor

kean commented Mar 20, 2025

We want app users to verify their email even more because some features (post preview, themes, domains, etc) won't work without auth cookies.

That's fair, but I would recommend to do that via the existing "Verify" view on the "Me" tab by using a red badge on the tab bar to guide the user there. There isn't a need for a separate entry point on the "No Site" view.

Base automatically changed from verify-email-address to trunk March 20, 2025 23:02
@crazytonyli
Copy link
Contributor Author

I'll close this PR then.

How do you even show a small red dot on tab bar? No matter what I do, I see this quite big bubble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User needs to login again in the in-app webview when creating their first site
3 participants