Move a few more utils types to WordPressShared #24210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24210-36822c1 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 36822c1 | |
| App Center Build | WPiOS - One-Offs #11662 |
They had to be moved in bulk because of circular dependencies.
We need it there because it's used by `SharedDataIssueSolver` which we'll soon need to move to WordPressData.
mokagio
force-pushed
the
mokagio/move-some-files-to-wordpressshared-2
branch
from
be379f0 to
ef101e5
Compare
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24210-36822c1 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 36822c1 | |
| App Center Build | jetpack-installable-builds #10690 |
mokagio
requested review from
kean and
crazytonyli
and removed request for
kean
crazytonyli
approved these changes
Mar 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
* Clobber all migrations mappings and policies — Very old For the sake of convenience and code maintenance, we decided to remove these migrations because we consider it safe to assume all existing users are on later versions. If no user will ever run the migrations, the code is essentially dead code that we can remove. For reference, the current version is 154 and the oldest migration was 91-to-92. The model version 92 dates back to 2019, see dcdba23 * Move a few more utils types to WordPressShared (#24210) - KeychainUtils & co - UserPersistentRepository & co - LocalFileStore & co
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #24207.
KeychainUtils& coUserPersistentRepository& coLocalFileStore& coWe'll need them there because it's used by
SharedDataIssueSolverwhich we'll soon need to move to WordPressData, part of #24165.Hopefully, this is helpful for the WordPressGuts work as well.