Skip to content

[Tooling] Migrate Prototype Builds from App Center to Firebase App Distribution #24199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 27, 2025
Merged

[Tooling] Migrate Prototype Builds from App Center to Firebase App Distribution #24199

merged 5 commits into from
Mar 27, 2025

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Mar 12, 2025 •
edited
Loading

Description

This migrates the Prototype Builds to be uploaded to Firebase App Distribution instead of App Center.

This is done in the context of App Center shutting down at the end of the month.

Internal references:

  • pdnsEh-1zD-p2
  • paaHJt-7S2-p2
  • 186-gh-Automattic/apps-infra-plans

Release Timing

Important

We might want to wait before merging this until our internal documentation—about how to use our internal tools to enroll to Firebase App Distribution—has been updated.

Testing

  • Validate that there are 2 distinct PR comments, one for WordPress and one for Jetpack
  • Check that the information shown in each PR comment looks accurate, including the build number (expected to be set to the Buildkite build number) and version (expected to use the PR number)
  • Add yourself to the WP and JP Testing Groups via our MC tool (/mobile/firebase-app-distribution/testers/), then accept the invitation email you received
  • Scan the QR code in each PR comment with your iPhone and confirm you can install the prototype build on your device for each app

AliSoftware
AliSoftware commented Mar 12, 2025
View reviewed changes
WordPress/Credentials/Secrets-example.swift
@@ -20,7 +20,6 @@ class ApiCredentials: NSObject {
// Other Services
static let tenorApiKey = ""
static let sentryDSN = ""
static let appCenterAppId = ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this PR lands, we might want to remove that constant from the actual Secrets-*.swift files in ~/.mobile-secrets (see .configure setup), as from a quick grep in the source code, this constant doesn't seem to be used anywhere in the codebase anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tracked in https://github.com/Automattic/apps-infra-plans/issues/219.

@AliSoftware AliSoftware force-pushed the tooling/migrate-from-appcenter-to-fad branch from 73fb69b to 196a2d1 Compare March 12, 2025 17:18
AliSoftware
AliSoftware commented Mar 12, 2025
View reviewed changes
fastlane/env/project.env-example
Comment on lines -4 to -5
APPCENTER_PUBLIC_ID=<AppCenter Public Id>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, once this PR lands, we might want to remove that env var value from the actual project.env file in ~/.mobile-secrets (see .configure setup), as it doesn't seem used anymore either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tracked in https://github.com/Automattic/apps-infra-plans/issues/219.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 12, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number26755
VersionPR #24199
Bundle IDcom.jetpack.alpha
Commit4593787
Installation URL0e6tsdou6qbqg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 12, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number26755
VersionPR #24199
Bundle IDorg.wordpress.alpha
Commit4593787
Installation URL4u9u6khptqg5g
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@AliSoftware AliSoftware self-assigned this Mar 12, 2025
@AliSoftware AliSoftware added the Tooling Build, Release, and Validation Tools label Mar 12, 2025
@AliSoftware AliSoftware modified the milestones: 25.9, 26.0 Mar 12, 2025
@AliSoftware AliSoftware marked this pull request as ready for review March 12, 2025 18:49
@AliSoftware AliSoftware requested a review from a team March 12, 2025 18:49
twstokes
twstokes approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AliSoftware AliSoftware force-pushed the tooling/migrate-from-appcenter-to-fad branch from 5b6bc02 to 95ac031 Compare March 19, 2025 21:02
iangmaia
iangmaia reviewed Mar 20, 2025
View reviewed changes
AliSoftware
AliSoftware commented Mar 27, 2025
View reviewed changes
Copy link
Contributor Author

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration has been officially announced internally and all the internal docs updated, so let's finally land this!! 🚀

WordPress/Credentials/Secrets-example.swift
@@ -20,7 +20,6 @@ class ApiCredentials: NSObject {
// Other Services
static let tenorApiKey = ""
static let sentryDSN = ""
static let appCenterAppId = ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tracked in https://github.com/Automattic/apps-infra-plans/issues/219.

fastlane/env/project.env-example
Comment on lines -4 to -5
APPCENTER_PUBLIC_ID=<AppCenter Public Id>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tracked in https://github.com/Automattic/apps-infra-plans/issues/219.

@AliSoftware AliSoftware enabled auto-merge March 27, 2025 13:14
@AliSoftware AliSoftware added this pull request to the merge queue Mar 27, 2025
Merged via the queue into trunk with commit 9348997 Mar 27, 2025
25 checks passed
@AliSoftware AliSoftware deleted the tooling/migrate-from-appcenter-to-fad branch March 27, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

@iangmaia iangmaia iangmaia approved these changes

Assignees

@AliSoftware AliSoftware

Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Milestone
26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AliSoftware @wpmobilebot @twstokes @iangmaia