[Tooling] Migrate Prototype Builds from App Center to Firebase App Distribution #24199
Conversation
| @@ -20,7 +20,6 @@ class ApiCredentials: NSObject { | |||
| // Other Services | |||
| static let tenorApiKey = "" | |||
| static let sentryDSN = "" | |||
| static let appCenterAppId = "" | |||
There was a problem hiding this comment.
Once this PR lands, we might want to remove that constant from the actual Secrets-*.swift files in ~/.mobile-secrets (see .configure setup), as from a quick grep in the source code, this constant doesn't seem to be used anywhere in the codebase anymore.
AliSoftware
force-pushed
the
tooling/migrate-from-appcenter-to-fad
branch
from
73fb69b to
196a2d1
Compare
| APPCENTER_PUBLIC_ID=<AppCenter Public Id> | ||
|
|
There was a problem hiding this comment.
Similarly, once this PR lands, we might want to remove that env var value from the actual project.env file in ~/.mobile-secrets (see .configure setup), as it doesn't seem used anymore either.
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 26410 | |
| Version | PR #24199 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 95ac031 | |
| Installation URL | 3ldgt8ainqqr0 |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 26410 | |
| Version | PR #24199 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 95ac031 | |
| Installation URL | 0h6497oq1odqo |
AliSoftware
force-pushed
the
tooling/migrate-from-appcenter-to-fad
branch
from
5b6bc02 to
95ac031
Compare
| # Attach version information as Buildkite metadata and annotation | ||
| appcenter_id = lane_context.dig(SharedValues::APPCENTER_BUILD_INFORMATION, 'id') | ||
| metadata = versions.merge(build_type: 'Prototype', 'appcenter:id': appcenter_id) | ||
| buildkite_metadata(set: metadata) | ||
| appcenter_install_url = "https://install.appcenter.ms/orgs/#{APPCENTER_OWNER_NAME}/apps/#{appcenter_app_name}/releases/#{appcenter_id}" | ||
| list = metadata.map { |k, v| " - **#{k}**: #{v}" }.join("\n") | ||
| buildkite_annotate(context: "appcenter-info-#{output_app_name}", style: 'info', message: "#{output_app_name} [App Center Build](#{appcenter_install_url}) Info:\n\n#{list}") |
There was a problem hiding this comment.
Not sure how useful this in fact is, but I was wondering if anyone would miss the Buildkite annotation / metadata?
There was a problem hiding this comment.
Yeah, in some repos I've kept them, in others I've removed them… not sure about it tbh.
Though this might also depend if people use the new Build UI from Buildkite or the classic one, given how annotations are shown a bit differently on the 2 UIs, and are more discreet on the new UI… which could either be in favor of keeping them (they won't hurt and not take extra space anyway) or removing them (who is going to check the annotations instead of clicking on the link to the GitHub PR to see the link to those in the PR comment anyway?
Ultimately I considered those were not that useful, especially for Prototype Builds (as keeping them would mean every single CI build would have an annotation, since every single commit generates a Prototype Build… for little benefit IMHO).
If I'm not mistaken, ultimately the only place/repos for which I kept those annotations are for Alpha and Betas builds, and only for products which are sending those to FAD (which to this day is only the case for Tumblr iOS & Android), given those alpha/beta builds are not attached to a PR so it felt useful to have the FAD link as annotation for those.
There was a problem hiding this comment.
Ultimately I considered those were not that useful, especially for Prototype Builds
Makes sense 👍
only the case for Tumblr iOS & Android, given those alpha/beta builds are not attached to a PR so it felt useful to have the FAD link as annotation for those
Indeed 👍
Description
This migrates the Prototype Builds to be uploaded to Firebase App Distribution instead of App Center.
This is done in the context of App Center shutting down at the end of the month.
Internal references:
Release Timing
Important
We might want to wait before merging this until our internal documentation—about how to use our internal tools to enroll to Firebase App Distribution—has been updated.
Testing
/mobile/firebase-app-distribution/testers/), then accept the invitation email you received