Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AsyncOperation and AsyncBlockOperation to WordPressShared #24185

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 11, 2025

I run into those as dependencies for the Core Data logic, see #24166 and #24165. There's lots to move in that PR, so I pushed this little self-contained change in the meantime.

I got bitten a few time by these changes where the app seems to compile fine but then crashes at runtime. So, I tested this "properly".

IMG_0031

mokagio added 2 commits March 11, 2025 13:33
This is so the diff is neater next when moving it to WordPressShared
Turned out there needed to be move access control changes than
those done in the previous commit...
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24185-0dba621
Version25.8
Bundle IDorg.wordpress.alpha
Commit0dba621
App Center BuildWPiOS - One-Offs #11626
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24185-0dba621
Version25.8
Bundle IDcom.jetpack.alpha
Commit0dba621
App Center Buildjetpack-installable-builds #10657
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio added this to the 25.9 milestone Mar 11, 2025
@mokagio mokagio requested review from crazytonyli and kean March 11, 2025 05:24
@mokagio mokagio added this pull request to the merge queue Mar 11, 2025
Merged via the queue into trunk with commit 69fc61b Mar 11, 2025
27 checks passed
@mokagio mokagio deleted the mokagio/asyncop branch March 11, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants