Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ImmuTable to dedicated package #24152

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 6, 2025

I was looking around the codebase and saw what looked like a quick win for modularization: move the ImmuTable implementation in a dedicated package.

This is just a little step forward towards more modularization and less time spend compiling.

WordPressUI could have been another destination for the logic. If you feel it's better to move it there, I'll follow up with a dedicated PR. The bulk of the work was to move it out of the main target anyway

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Mar 6, 2025

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 6, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24152-d4441a7
Version25.7.1
Bundle IDorg.wordpress.alpha
Commitd4441a7
App Center BuildWPiOS - One-Offs #11588
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 6, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24152-d4441a7
Version25.7.1
Bundle IDcom.jetpack.alpha
Commitd4441a7
App Center Buildjetpack-installable-builds #10618
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

mokagio added 3 commits March 6, 2025 12:34
It was easier than identifying the access control relationships, change
them for the purpose of moving the files, then updating once the move
was completed.
I run the extraction building the Jetpack target which clearly misses
some of the tests.
@mokagio
Copy link
Contributor Author

mokagio commented Mar 11, 2025

FYI @kean @crazytonyli I started this when first looking into this round of modularization but then paused it for the Core Data stuff. I don't consider it urgent but wanted to let you know about it in case you end up touching the ImmuTable- pieces.

@kean
Copy link
Contributor

kean commented Mar 11, 2025

Oh looks like I removed some of the code that was using it. We don't really use this type anymore. For forms, we stick with SwiftUI.

@mokagio
Copy link
Contributor Author

mokagio commented Mar 12, 2025

Oh looks like I removed some of the code that was using it.
Excellent

For forms, we stick with SwiftUI.
This is the way

@mokagio
Copy link
Contributor Author

mokagio commented Mar 12, 2025

I'll see whether to continue with this or drop once done with #24165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants