Skip to content

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Sep 27, 2021

What it says in the title 😅

To test: If CI can build and run the UI tests, we're good.

Regression Notes

  1. Potential unintended areas of impact
    N.A.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N.A.

  3. What automated tests I added (or what prevented me from doing so)
    N.A.


  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

@mokagio mokagio added the Testing Unit and UI Tests and Tooling label Sep 27, 2021
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@mokagio mokagio marked this pull request as ready for review September 27, 2021 05:11
@mokagio mokagio enabled auto-merge September 27, 2021 05:11
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@mokagio mokagio added this to the 18.4 milestone Sep 27, 2021
Copy link
Contributor

@nikola-milicevic nikola-milicevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@mokagio mokagio merged commit 789954a into develop Sep 27, 2021
@mokagio mokagio deleted the remove-unused-code-actionsheet branch September 27, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Unit and UI Tests and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants