-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Removed job from Jetpack connection flow #22153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the unused Job
from the Jetpack REST connection flow, simplifying the implementation by eliminating unnecessary job management. The original intent was to make the flow cancellable, but since there's no practical way to cancel individual steps, the Job
was redundant.
- Removed
Job
import and related job management code - Renamed methods from "job" to "flow" terminology for clarity
- Updated logging messages to reflect the change from "job" to "flow"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...c/main/java/org/wordpress/android/ui/jetpackrestconnection/JetpackRestConnectionViewModel.kt
Show resolved
Hide resolved
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr22153-b565a29 | |
Commit | b565a29 | |
Direct Download | wordpress-prototype-build-pr22153-b565a29.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr22153-b565a29 | |
Commit | b565a29 | |
Direct Download | jetpack-prototype-build-pr22153-b565a29.apk |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22153 +/- ##
=======================================
Coverage 39.13% 39.13%
=======================================
Files 2157 2157
Lines 102709 102709
Branches 15773 15773
=======================================
Hits 40196 40196
Misses 58938 58938
Partials 3575 3575 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up, LGTM!
As mentioned here, using a
Job
for the Jetpack connection flow doesn't make sense.The original intent was to use a
Job
so the flow could be cancellable, but there's really no way to cancel any of the steps. So this PR removes theJob
entirely.