Jetpack REST connection: connect site and user #22126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir is an HTTP status code
…ir is an HTTP status code
…-Android into feature/jetpack-connect-install
Generated by 🚫 Danger |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22126-6185c2d | |
| Commit | 6185c2d | |
| Direct Download | wordpress-prototype-build-pr22126-6185c2d.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22126-6185c2d | |
| Commit | 6185c2d | |
| Direct Download | jetpack-prototype-build-pr22126-6185c2d.apk |
There was a problem hiding this comment.
Pull Request Overview
This PR implements the "connect site" and "connect user" steps in the Jetpack REST connection flow for the WordPress Android app. The changes enable automatic site connection to WordPress.com and user authentication through the Jetpack plugin installation process.
Key changes:
- Added actual implementation for Jetpack plugin installation and site/user connection steps
- Created new helper classes (
JetpackInstaller,JetpackConnector,JetpackConnectionHelper) to handle the connection logic - Updated UI strings and error handling to reflect the new connection flow
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
strings.xml |
Updated step labels and added new error messages for connection failures |
JetpackRestConnectionViewModel.kt |
Implemented actual connection logic replacing placeholder code, added new dependencies and error types |
JetpackRestConnectionScreen.kt |
Updated UI to reflect renamed connection steps and new error types |
JetpackInstaller.kt |
New class implementing Jetpack plugin installation using wordpress-rs API |
JetpackConnector.kt |
New class handling site and user connection to WordPress.com |
JetpackConnectionHelper.kt |
New helper class for initializing API clients with authentication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...c/main/java/org/wordpress/android/ui/jetpackrestconnection/JetpackRestConnectionViewModel.kt
Outdated
Show resolved
Hide resolved
...c/main/java/org/wordpress/android/ui/jetpackrestconnection/JetpackRestConnectionViewModel.kt
Outdated
Show resolved
Hide resolved
...c/main/java/org/wordpress/android/ui/jetpackrestconnection/JetpackRestConnectionViewModel.kt
Outdated
Show resolved
Hide resolved
…-Android into feature/jetpack-connect-site-and-user Conflicts: WordPress/src/main/java/org/wordpress/android/ui/jetpackrestconnection/JetpackInstaller.kt WordPress/src/main/java/org/wordpress/android/ui/jetpackrestconnection/JetpackRestConnectionScreen.kt WordPress/src/main/java/org/wordpress/android/ui/jetpackrestconnection/JetpackRestConnectionViewModel.kt WordPress/src/main/res/values/strings.xml
|
adalpari
reviewed
Aug 18, 2025
Comment on lines
+20
to
+26
| fun initWpApiClient(site: SiteModel): WpApiClient { | ||
| requireRestCredentials(site) | ||
| return WpApiClient( | ||
| wpOrgSiteApiRootUrl = URL(resolveRestApiUrl(site)), | ||
| authProvider = createRestAuthProvider(site) | ||
| ) | ||
| } |
There was a problem hiding this comment.
⛏️ I know I have already mentioned this, but what about keeping all the WpApiClient creations inside the WpApiClientProviderso the maintenante is clearer?
There was a problem hiding this comment.
Yep, this is already a task on the Linear project. I'll DM you the project link.
adalpari
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "connect site" and "connect user" steps to the Jetpack REST connection flow.
To test
Note: The connection flow will then appear stuck on the "Finalize setup" step. This will be addressed in a separate PR.
Screen_recording_20250813_153323.mp4