Subscriber plans #21984
Subscriber plans #21984
Conversation
Generated by 🚫 Danger |
…-Android into feature/subscriber-plans Conflicts: WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscriberDetailScreen.kt WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscribersActivity.kt
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21984-beb4213 | |
| Commit | beb4213 | |
| Direct Download | wordpress-prototype-build-pr21984-beb4213.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21984-beb4213 | |
| Commit | beb4213 | |
| Direct Download | jetpack-prototype-build-pr21984-beb4213.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21984 +/- ##
=======================================
Coverage 39.02% 39.02%
=======================================
Files 2153 2153
Lines 101494 101494
Branches 15585 15585
=======================================
Hits 39613 39613
Misses 58384 58384
Partials 3497 3497 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR enables viewing detailed subscriber plan information by extending the navigation flow and introducing a dedicated plan screen.
- Added navigation state and route for a new Plan screen in
SubscribersActivity - Introduced
SubscriberPlanScreencomposable with associated UI cards and icons - Updated
SubscriberDetailScreento display plan items as clickable entries and added new string resources and icons
Comments suppressed due to low confidence (2)
WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscriberPlanScreen.kt:46
- This new
SubscriberPlanScreenComposable introduces significant UI logic but lacks associated unit or UI tests; consider adding tests to cover rendering states (active, inactive, gift).
@Composable
WordPress/src/main/java/org/wordpress/android/ui/subscribers/SubscriberDetailScreen.kt:255
- Missing import for
clickable: please addimport androidx.compose.foundation.clickableto avoid unresolved reference errors.
modifier = Modifier.clickable {
| } | ||
| } | ||
|
|
||
| private fun SubscriptionPlan.isActive() = status.lowercase() == "active" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| titleState.value = subscriber.plans!![planIndex].title | ||
| SubscriberPlanScreen( | ||
| plan = subscriber.plans!![planIndex], | ||
| modifier = Modifier.padding(contentPadding) | ||
| ) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| val currency = Currency.getInstance(currencyCode) | ||
| val formatter = NumberFormat.getCurrencyInstance(Locale.getDefault()) | ||
| formatter.currency = currency | ||
| formatter.format(amount) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
This PR enables viewing a subscriber's plan details. To test:
plan.mp4