Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 전체적인 패키지 구조 변경 #977

Merged
merged 5 commits into from
Mar 11, 2025
Merged

Conversation

kimhm0728
Copy link
Contributor

🚩 연관 이슈

close #976


📝 작업 내용

  • presentation 하위에 있었던 화면 별 패키지를 presentation/feature로 이동
  • data 패키지 local/repository와 remote/repository를 data/repository로 통합
  • data/retrofit을 remote로 이동

🏞️ 스크린샷 (선택)


🗣️ 리뷰 요구사항 (선택)

컴포즈 도입하면 presentation 하위에 component, theme 패키지가 생길 것 같아요.
그런데 presentation 같은 레벨에 화면 별 패키지, component, theme가 모두 있는게 어색하고 복잡하다고 느껴져서
화면 별 패키지들은 presentation/feature 패키지로 묶어주었습니다! 괜찮은가요?

- retrofit 패키지를 remote로 이동
- local, remote repository 패키지를 data 패키지 하위에 이동
- retrofit 패키지를 remote로 이동
- local, remote repository 패키지를 data 패키지 하위에 이동
# Conflicts:
#	android/app/src/main/java/com/mulberry/ody/di/RepositoryModule.kt
@kimhm0728 kimhm0728 requested a review from haeum808 March 5, 2025 14:54
@kimhm0728 kimhm0728 self-assigned this Mar 5, 2025
@haeum808
Copy link
Contributor

haeum808 commented Mar 8, 2025

확실히 presentation에 변경이 필요하겠네요! 고생하셨습니다!

드디어 retrofit이 옮겨졌군요! 굿굿

@kimhm0728 kimhm0728 merged commit 26ba953 into develop Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: 전체적인 패키지 구조 변경
2 participants