-
Notifications
You must be signed in to change notification settings - Fork 120
[WCiOS17] Address remaining WPAuth warnings #16437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iamgabrielma
wants to merge
8
commits into
task/wcios17-map-picker
Choose a base branch
from
task/wcios17-remaining-wpauth-warnings
base: task/wcios17-map-picker
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WCiOS17] Address remaining WPAuth warnings #16437
iamgabrielma
wants to merge
8
commits into
task/wcios17-map-picker
from
task/wcios17-remaining-wpauth-warnings
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
RafaelKayumov
approved these changes
Dec 8, 2025
Contributor
RafaelKayumov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: task
An internally driven task.
type: technical debt
Represents or solves tech debt of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Part of, closes WOOMOB-1003
Description
This PR should be the last remaining issue from clearing all iOS17-related warnings. We update the trait observation for the remaining items from the WPAuth library:
SiteInfoHeaderView: Used for login into self-hosted sites (LoginSelfHostedViewController,LoginUsernamePasswordViewController)NuxButtonand its stacked variant: used all around, but mostly around login/auth flows.SubheadlineButton: only used for stylingsignupTermsButton(in the button to open our Terms & conditions)Test Steps
As with previous ones I tested the login flow for self hosted site, and both the orientation and dark/light switches seem to work correctly, but looping Kiwi since you see those flows much more often. Let me know if anything seems off.