Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Dec 5, 2025

Part of, closes WOOMOB-1003

Description

This PR should be the last remaining issue from clearing all iOS17-related warnings. We update the trait observation for the remaining items from the WPAuth library:

  • SiteInfoHeaderView: Used for login into self-hosted sites (LoginSelfHostedViewController, LoginUsernamePasswordViewController)
  • NuxButton and its stacked variant: used all around, but mostly around login/auth flows.
  • SubheadlineButton: only used for styling signupTermsButton (in the button to open our Terms & conditions)

Test Steps

As with previous ones I tested the login flow for self hosted site, and both the orientation and dark/light switches seem to work correctly, but looping Kiwi since you see those flows much more often. Let me know if anything seems off.

@dangermattic
Copy link
Collaborator

dangermattic commented Dec 5, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added type: task An internally driven task. type: technical debt Represents or solves tech debt of the project. labels Dec 5, 2025
@iamgabrielma iamgabrielma added this to the 23.9 milestone Dec 5, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review December 5, 2025 04:50
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16437-48b63fe
Version23.8
Bundle IDcom.automattic.alpha.woocommerce
Commit48b63fe
Installation URL5vtf8tjhmg4go
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task. type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants