[WCiOS17] Bump minimum deployment target to iOS17

[iamgabrielma]

Closes WOOMOB-1000. Part of WOOMOB-1003

Description

This PR bumps WooCommerce iOS minimum deployment target to iOS17.

Testing information

• When building the app in Xcode you'll see ~200 warnings, we'll be addressing these as part of the project.
• You might need to close Xcode, and clean the build folder before building the app. It generally worked fine on my end after clearing the build folder and re-opening Xcode, then rebuilding on the first try.
• Running the app on an iOS17+ device and simulator should run it normally.

Tested on iPhone 14 running 17.6.1, and simulators running 18+

Screenshots

N/A

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	pr16003-1282948
	Version	23.0
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	1282948
	Installation URL	0ssjqdsmjdfro

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[iamgabrielma]

Only 1 review is needed!

[staskus]

Thanks!

All these repeating changes suggest that there should be another part of the code that switches from 16.0 -> 17.0 in a more centralized place.

In this case I think are two files that need to be updated:

• /config/Common.xcconfig
• Package.swift

There comes from the new apps infra created module infrastructure.

[dangermattic]

	1 Warning
⚠️	Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

Generated by 🚫 Danger

[iamgabrielma]

Thanks!

All these repeating changes suggest that there should be another part of the code that switches from 16.0 -> 17.0 in a more centralized place.

In this case I think are two files that need to be updated:

• /config/Common.xcconfig
• Package.swift

There comes from the new apps infra created module infrastructure.

Thanks for the review! Interestingly, the common.xcconfig file is not findable in Xcode, but has to be updated via finder. Is good to know that we have this to update all targets though, I would have expected some compiler error or warning in any case by missing this bit 🤔

Addressed here: 45730e4

[iamgabrielma]

Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

I did resolve these in Xcode after updating the config, but there was no updates/changes to commit, so we should be good to go here.

@itsmeichigo if you have the time this week could you please take a look into this one? As Povilas will be AFK the rest of the week and I'll be AFK next week 😅

If you don't have the time that's fine, no rush! 🙇

[staskus]

@iamgabrielma I think all these should be reverted, since they are probably overriding the common config file.

[iamgabrielma]

Ooof you're right, sorry for the back and forth. Confirmed that after reverting on d50f5ee that we still see the targets individually marked as 17.0 under General and builds normally. So it would seem that after the infra changes the only needs are, as you mentioned:

/config/Common.xcconfig
/Modules/Package.swift 

[itsmeichigo]

The app builds and runs successfully. Project settings all display the iOS 17 as the target deployment.

[iamgabrielma]

Seems we're blocked from merging until you approve it @staskus ! 😂

I'll leave this one in auto-merge for now, no rush!