[WCiOS17] Update .onchange() usage to iOS17 API

WooCommerce/Classes/POS/Presentation/Barcode Scanner Setup/PointOfSaleBarcodeScannerSetup.swift

@@ -174,7 +174,7 @@ private struct AnimatedTransitionContainer<Content: View, ID: Equatable>: View {
                         .onAppear {
                             updateSize(to: proxy.size.height)
                         }
-                        .onChange(of: proxy.size) { newSize in
+                        .onChange(of: proxy.size) { _, newSize in
                             updateSize(to: newSize.height)
                         }
                 }
@@ -186,7 +186,7 @@ private struct AnimatedTransitionContainer<Content: View, ID: Equatable>: View {
             .onAppear {
                 hasAppeared = true
             }
-            .onChange(of: contentID) { newID in
+            .onChange(of: contentID) { _, newID in
                 guard newID != previousID else { return }
 
                 if hasAppeared {

WooCommerce/Classes/POS/Presentation/CartView.swift

@@ -276,11 +276,11 @@ private struct CartScrollViewContent: View {
                     .onAppear {
                         updateItemImageVisibility(cartListWidth: geometry.size.width)
                     }
-                    .onChange(of: geometry.size.width) {
-                        updateItemImageVisibility(cartListWidth: $0)
+                    .onChange(of: geometry.size.width) { _, newValue in
+                        updateItemImageVisibility(cartListWidth: newValue)
                     }
-                    .onChange(of: dynamicTypeSize) {
-                        updateItemImageVisibility(dynamicTypeSize: $0, cartListWidth: geometry.size.width)
+                    .onChange(of: dynamicTypeSize) { _, newValue in
+                        updateItemImageVisibility(dynamicTypeSize: newValue, cartListWidth: geometry.size.width)
                     }
                 })
                 .onPreferenceChange(ScrollOffSetPreferenceKey.self) { position in
@@ -303,7 +303,7 @@ private struct CartScrollViewContent: View {
                 scrollViewHeight = height
             }
             .coordinateSpace(name: Constants.scrollViewCoordinateSpaceIdentifier)
-            .onChange(of: posModel.cart.purchasableItems.first?.id) { itemToScrollTo in
+            .onChange(of: posModel.cart.purchasableItems.first?.id) { _, itemToScrollTo in
                 if posModel.orderStage == .building {
                     withAnimation {
                         proxy.scrollTo(itemToScrollTo)
@@ -405,7 +405,7 @@ private struct PurchasableItemsCartSection: View {
                 .transition(.opacity)
                 .accessibilityFocused($accessibilityFocusedItem, equals: cartItem.id)
             }
-            .onChange(of: posModel.cart.accessibilityFocusedItemID) { itemID in
+            .onChange(of: posModel.cart.accessibilityFocusedItemID) { _, itemID in
                  if let itemID = itemID {
                      Task { @MainActor in
                          accessibilityFocusedItem = itemID

WooCommerce/Classes/POS/Presentation/Infinite Scroll/InfiniteScrollView.swift

@@ -28,7 +28,7 @@ struct InfiniteScrollView<Content: View>: View {
                 .background(
                     GeometryReader { proxy in
                         Color.clear
-                            .onChange(of: proxy.frame(in: .named(Constants.scrollViewNamespace)).maxY) { maxY in
+                            .onChange(of: proxy.frame(in: .named(Constants.scrollViewNamespace)).maxY) { _, maxY in
                                 let contentHeight = proxy.size.height
                                 let scrollPosition = contentHeight - maxY
 

WooCommerce/Classes/POS/Presentation/PointOfSaleCollectCashView.swift

@@ -57,7 +57,7 @@ struct PointOfSaleCollectCashView: View {
                                         await submitCashAmount()
                                     }
                                 }
-                                .onChange(of: textFieldViewModel.amount) { newValue in
+                                .onChange(of: textFieldViewModel.amount) { _, newValue in
                                     textFieldAmountInput = newValue
                                     updateChangeDueMessage()
                                 }
@@ -100,7 +100,7 @@ struct PointOfSaleCollectCashView: View {
                 .frame(minHeight: geometry.size.height)
                 .animation(.easeInOut, value: errorMessage)
                 .animation(.easeInOut, value: changeDueMessage != nil)
-                .onChange(of: textFieldAmountInput) { _ in
+                .onChange(of: textFieldAmountInput) {
                     errorMessage = nil
                 }
                 .onReceive(Publishers.keyboardFrame) {

WooCommerce/Classes/POS/Presentation/Reusable Views/POSModalViewModifier.swift

@@ -80,7 +80,7 @@ struct POSModalViewModifier<Item: Identifiable & Equatable, ModalContent: View>:
 
     func body(content: Content) -> some View {
         content
-            .onChange(of: item) { newItem in
+            .onChange(of: item) { _, newItem in
                 if let newItem = newItem {
                     modalManager.present(onDismiss: {
                         // Internal dismissal, i.e. from tapping the background
@@ -106,7 +106,7 @@ struct POSModalViewModifierForBool<ModalContent: View>: ViewModifier {
 
     func body(content: Content) -> some View {
         content
-            .onChange(of: isPresented) { newValue in
+            .onChange(of: isPresented) { _, newValue in
                 if newValue {
                     modalManager.present(onDismiss: {
                         // Internal dismissal, i.e. from tapping the background
@@ -174,7 +174,7 @@ struct POSInteractiveDismissModifier: ViewModifier {
 
     func body(content: Content) -> some View {
         content
-            .onChange(of: disabled) { newValue in
+            .onChange(of: disabled) { _, newValue in
                 modalManager.setInteractiveDismissal(!newValue)
             }
             .onAppear {

WooCommerce/Classes/POS/Presentation/Reusable Views/POSSendReceiptView.swift

@@ -80,7 +80,7 @@ struct POSSendReceiptView: View {
                 .padding(.bottom, keyboardFrame.height)
             }
             .animation(.easeInOut, value: errorMessage)
-            .onChange(of: textFieldInput) { _ in
+            .onChange(of: textFieldInput) {
                 errorMessage = nil
             }
             .onReceive(Publishers.keyboardFrame) {

WooCommerce/Classes/POS/Presentation/Reusable Views/POSSheet.swift

@@ -41,7 +41,7 @@ struct POSSheetViewModifier<SheetContent: View>: ViewModifier {
     func body(content: Content) -> some View {
         content
             .sheet(isPresented: $isPresented, onDismiss: onDismiss, content: sheetContent)
-            .onChange(of: isPresented) { newValue in
+            .onChange(of: isPresented) { _, newValue in
                 if newValue {
                     sheetManager.registerSheetPresented(id: sheetId)
                 } else {
@@ -62,7 +62,7 @@ struct POSSheetViewModifierForItem<Item: Identifiable & Equatable, SheetContent:
     func body(content: Content) -> some View {
         content
             .sheet(item: $item, onDismiss: onDismiss, content: sheetContent)
-            .onChange(of: item) { newItem in
+            .onChange(of: item) { _, newItem in
                 let newValue = newItem != nil
                 if newValue {
                     sheetManager.registerSheetPresented(id: sheetId)

WooCommerce/Classes/POS/Presentation/TotalsView.swift

@@ -79,7 +79,9 @@ struct TotalsView: View {
         .onAppear {
             isShowingTotalsFields = shouldShowTotalsFields
         }
-        .onChange(of: shouldShowTotalsFields, perform: hideTotalsFieldsWithDelay)
+        .onChange(of: shouldShowTotalsFields) {
+            hideTotalsFieldsWithDelay(shouldShowTotalsFields)
+        }
         .geometryGroup()
     }
 

WooCommerce/Classes/POS/TabBar/POSIneligibleView.swift

@@ -98,7 +98,7 @@ struct POSIneligibleView: View {
             .onAppear {
                 ServiceLocator.analytics.track(event: .PointOfSaleIneligibleUI.ineligibleUIShown(reason: reason))
             }
-            .onChange(of: reason) { newReason in
+            .onChange(of: reason) { _, newReason in
                 ServiceLocator.analytics.track(event: .PointOfSaleIneligibleUI.ineligibleUIShown(reason: newReason))
             }
         }

WooCommerce/Classes/View Modifiers/View+NoticesModifier.swift

@@ -120,7 +120,7 @@ struct NoticeModifier: ViewModifier {
                             performClearNoticeTask()
                         })
                     )
-                    .onChange(of: notice) { _ in
+                    .onChange(of: notice) {
                         provideHapticFeedbackIfNecessary(notice.feedbackType)
                         dispatchClearNoticeTask()
                     }

WooCommerce/Classes/ViewRelated/Coupons/Add and Edit Coupons/CouponExpiryDateView.swift

@@ -18,7 +18,7 @@ struct CouponExpiryDateView: View {
                         .environment(\.timeZone, timezone)
                         .datePickerStyle(GraphicalDatePickerStyle())
                         .padding(.vertical, Constants.datePickerVerticalMargin)
-                        .onChange(of: date) { _ in
+                        .onChange(of: date) {
                             isRemovalEnabled = true
                         }
                     VStack {

WooCommerce/Classes/ViewRelated/Custom Fields/CustomFieldEditorView.swift

@@ -62,7 +62,7 @@ struct CustomFieldEditorView: View {
                                 Text(Localization.editorPickerHTML).tag(true)
                             }
                             .pickerStyle(.segmented)
-                            .onChange(of: showRichTextEditor) { newValue in
+                            .onChange(of: showRichTextEditor) { _, newValue in
                                 viewModel.trackEditorPickerTapped(showRichTextEditor: newValue)
                             }
                         }

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/Tap to Pay Education/TapToPayEducationView.swift

@@ -58,7 +58,7 @@ struct TapToPayEducationView: View {
             }
         }
         .interactiveDismissDisabled(viewModel.isInteractiveDismissDisabled)
-        .onChange(of: viewModel.dismiss) { _ in
+        .onChange(of: viewModel.dismiss) {
             dismiss()
         }
         .onAppear {

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Help/SystemStatusReport/SystemStatusReportView.swift

@@ -60,7 +60,7 @@ struct SystemStatusReportView: View {
                   primaryButton: .default(Text(Localization.tryAgainButton), action: viewModel.fetchReport),
                   secondaryButton: .default(Text(Localization.cancelButton), action: dismissAction))
         }
-        .onChange(of: viewModel.errorFetchingReport) { newValue in
+        .onChange(of: viewModel.errorFetchingReport) { _, newValue in
             showingErrorAlert = newValue
         }
         .toolbar {

WooCommerce/Classes/ViewRelated/Orders/Order Creation/CustomAmounts/AddCustomAmountPercentageView.swift

@@ -65,7 +65,9 @@ private extension AddCustomAmountPercentageView {
                           text: $text,
                           prompt: Text("0").foregroundColor(Color(.textSubtle))
                 )
-                .onChange(of: text, perform: onChangeText)
+                .onChange(of: text) {
+                    onChangeText(text)
+                }
                 .focused()
                 .focused($focusPercentageInput)
                 .keyboardType(.decimalPad)

WooCommerce/Classes/ViewRelated/Orders/Order Creation/OrderForm.swift

@@ -235,7 +235,7 @@ struct OrderForm: View {
             .onAppear {
                 updateSelectionSyncApproach(for: presentationStyle)
             }
-            .onChange(of: horizontalSizeClass) { _ in
+            .onChange(of: horizontalSizeClass) {
                 viewModel.saveInFlightOrderNotes()
                 viewModel.saveInflightCustomerDetails()
             }

WooCommerce/Classes/ViewRelated/Orders/Order Creation/ProductsSection/DiscountLineDetailsView.swift

@@ -64,7 +64,9 @@ private extension DiscountLineDetailsView {
 
         var body: some View {
             TextField(placeholder, text: $text)
-                .onChange(of: text, perform: onChangeText)
+                .onChange(of: text) {
+                    onChangeText(text)
+                }
                 .focused()
                 .keyboardType(.numbersAndPunctuation)
                 .frame(maxWidth: .infinity, minHeight: Layout.rowHeight)

WooCommerce/Classes/ViewRelated/Orders/Order Details/Address Edit/FilterListSelector.swift

@@ -50,7 +50,7 @@ struct FilterListSelector<ViewModel: FilterListSelectorViewModelable>: View {
         VStack(spacing: 0) {
             SearchHeader(text: $searchTerm, placeholder: viewModel.filterPlaceholder)
                 .background(Color(.listForeground(modal: false)))
-                .onChange(of: searchTerm) { newValue in
+                .onChange(of: searchTerm) { _, newValue in
                     viewModel.searchTerm = newValue
                 }
 

WooCommerce/Classes/ViewRelated/Orders/Order Details/Receipts/ReceiptEmail/ReceiptEmailView.swift

@@ -45,8 +45,8 @@ struct ReceiptEmailView: View {
                     })
                 }
             }
-            .onChange(of: viewModel.state) { state in
-                if state == .success {
+            .onChange(of: viewModel.state) { _, newState in
+                if newState == .success {
                     DispatchQueue.main.asyncAfter(deadline: .now() + 0.6) {
                         dismiss()
                     }

WooCommerce/Classes/ViewRelated/Products/ProductSelector/ProductSelectorView.swift

@@ -169,9 +169,9 @@ struct ProductSelectorView: View {
             viewModel.onLoadTrigger.send()
             updateSyncApproach(for: horizontalSizeClass)
         }
-        .onChange(of: horizontalSizeClass, perform: { newSizeClass in
+        .onChange(of: horizontalSizeClass) { _, newSizeClass in
             updateSyncApproach(for: newSizeClass)
-        })
+        }
         // On the order form, this is not connected; the OrderForm displays the notices.
         .notice($viewModel.notice, autoDismiss: false)
         .sheet(isPresented: $showingFilters) {
@@ -319,7 +319,7 @@ private extension ProductSelectorView {
             .onAppear(perform: {
                 adjustViewWidthIfNeeded(using: geometry.size.width)
             })
-            .onChange(of: geometry.size.width) { newViewWidth in
+            .onChange(of: geometry.size.width) { _, newViewWidth in
                 adjustViewWidthIfNeeded(using: newViewWidth)
             }
         }

WooCommerce/Classes/ViewRelated/Products/ProductSelector/ProductStepper.swift

@@ -49,7 +49,7 @@ struct ProductStepper: View {
             .multilineTextAlignment(.center)
             .fixedSize(horizontal: true, vertical: false)
             .focused($textFieldFocused)
-            .onChange(of: textFieldFocused) { newValue in
+            .onChange(of: textFieldFocused) { _, newValue in
                 // We may have unsaved changes in the text field, if switching focus to another text field.
                 if newValue == false {
                     viewModel.resetEnteredQuantity()

WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/ExpandableBottomSheet.swift

@@ -59,11 +59,11 @@ struct ExpandableBottomSheet<AlwaysVisibleContent, ExpandableContent>: View wher
                         }
                     }
                     .trackSize(size: $expandingContentSize)
-                    .onChange(of: expandingContentSize, perform: { _ in
+                    .onChange(of: expandingContentSize) {
                         withAnimation {
                             panelHeight = calculateHeight()
                         }
-                    })
+                    }
                 }
                 .scrollVerticallyIfNeeded()
 
@@ -79,7 +79,7 @@ struct ExpandableBottomSheet<AlwaysVisibleContent, ExpandableContent>: View wher
             // Always visible content
             alwaysVisibleContent()
                 .trackSize(size: $fixedContentSize)
-                .onChange(of: fixedContentSize, perform: { [fixedContentSize] _ in
+                .onChange(of: fixedContentSize) {
                     guard fixedContentSize.width > 0,
                           fixedContentSize.height > 0 else {
                         // No animation for initial load
@@ -88,7 +88,7 @@ struct ExpandableBottomSheet<AlwaysVisibleContent, ExpandableContent>: View wher
                     withAnimation {
                         panelHeight = calculateHeight()
                     }
-                })
+                }
                 .contentShape(Rectangle())
                 .onTapGesture {
                     withAnimation {
@@ -104,25 +104,24 @@ struct ExpandableBottomSheet<AlwaysVisibleContent, ExpandableContent>: View wher
                         panelHeight = calculateHeight()
                     }
                 })
-                .onChange(of: geometryProxy.size.height,
-                          perform: { newValue in
+                .onChange(of: geometryProxy.size.height) { _, newValue in
                     if !isDragging {
                         DispatchQueue.main.async {
                             withAnimation {
                                 panelHeight = calculateHeight()
                             }
                         }
                     }
-                })
+                }
         })
-        .onChange(of: isExpanded, perform: { newValue in
+        .onChange(of: isExpanded) { _, newValue in
             onChangeOfExpansion?(newValue)
             DispatchQueue.main.async {
                 withAnimation {
                     panelHeight = calculateHeight()
                 }
             }
-        })
+        }
         .frame(maxWidth: .infinity, maxHeight: panelHeight, alignment: .bottom)
         .background(Color(.listForeground(modal: false)), ignoresSafeAreaEdges: .vertical)
         .cornerRadius(Layout.sheetCornerRadius)
@@ -220,7 +219,7 @@ struct SizeTracker: ViewModifier {
                     .onAppear {
                         self.size = proxy.size
                     }
-                    .onChange(of: proxy.size) { newSize in
+                    .onChange(of: proxy.size) { _, newSize in
                         self.size = newSize
                     }
             })

WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/FeedbackView.swift

@@ -58,7 +58,7 @@ struct FeedbackView: View {
             configuration.backgroundColor
                 .cornerRadius(Layout.cornerRadius)
         )
-        .onChange(of: vote) { newValue in
+        .onChange(of: vote) { _, newValue in
             if let newValue {
                 configuration.onVote(newValue)
             }

WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/ModalOverlay.swift

@@ -44,7 +44,7 @@ struct ModalOverlay<OverlayContent: View>: View {
                 .animation(.easeInOut(duration: 0.25), value: internalIsPresented)
             }
         }
-        .onChange(of: isPresented) { newValue in
+        .onChange(of: isPresented) { _, newValue in
             withAnimation {
                 internalIsPresented = newValue
             }

WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/MultiSelectionList.swift

@@ -111,7 +111,7 @@ struct MultiSelectionList<T: Hashable & Identifiable>: View {
             }
             .listStyle(.grouped)
         }
-        .onChange(of: query) { value in
+        .onChange(of: query) { _, value in
             onQueryChanged?(value)
         }
     }

WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/TitleAndTextFieldRow.swift

@@ -66,9 +66,9 @@ struct TitleAndTextFieldRow: View {
             HStack {
                 TextField(placeholder, text: $text, onEditingChanged: onEditingChanged ?? { _ in })
                     .foregroundColor(contentColor)
-                    .onChange(of: text, perform: { newValue in
+                    .onChange(of: text) { _, newValue in
                         text = formatText(newValue)
-                    })
+                    }
                     .onAppear {
                         text = formatText(text)
                     }