Track the reconnect notice and button clicks

[wjrosa]

Fixes STRIPE-740

Changes proposed in this Pull Request:

To complement #4669, this PR will add tracking for the "Reconnect to Stripe" button clicks (for both the admin notice and the main button in the settings screen).

Testing instructions

• Checkout and build this branch on your test environment (add/tracking-account-reconnect-notice-click)
• Connect your Stripe account
• Set up your store to behave as if it did not connect via OAuth by removing the connection_type (or test_connection_type attr from the settings:

wp option patch delete woocommerce_stripe_settings test_connection_type

• Click the "Reconnect to Stripe" button (either from the admin notice or the main button in the Stripe settings screen)
• In about 5 minutes, check MC Tracks Live events page for the presence of a wcstripe_reconnect_button_click event

---

• Covered with tests (or have a good reason not to test in description ☝️)
• Tested on mobile (or does not apply)

Changelog entry

• This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Comment

Comment

Post merge

• Added testing instructions to the Release Testing Instructions wiki page (or does not apply)
• Added the needs docs label (or does not apply)
• Included this PR in the Release Thread scope (or does not apply)

[malithsen]

@wjrosa I might need some additional help testing this. I tried deleting the test_connection_type key/value pair from the settings option. That forced me to reconnect via the initial connection screen (No "Reconnect to Stripe" button)

I also tried hard-coding oauthConnected = false but I couldn't get account-details-section.js component to get called at all. I might be looking at the wrong views. Do you mind sharing a screenshot?

EDIT:
nvm, I was making changes on my local site while looking at a separate JN site 🤦

[diegocurbelo]

This is working as indicated, my only nitpick is that we are not actually tracking the click in the admin notice button, but the page load it triggers (&highlight=account-details), so page refreshes will count towards it 🤷🏼

Also, maybe we should also track the Re-authenticate button to get the full picture:

[malithsen]

Code looks good, agreeing with Diego's feedback.

[wjrosa]

Thanks for the review, folks!

This is working as indicated, my only nitpick is that we are not actually tracking the click in the admin notice button, but the page load it triggers (&highlight=account-details), so page refreshes will count towards it 🤷🏼

That's a good point. I refactored the code in f348c35 to actually track the click instead of the page scroll. I had to use raw JS since I could not import the existing Tracks component there.

Also, maybe we should also track the Re-authenticate button to get the full picture:

Added tracking for that in 79025c6

[malithsen]

Changes look good to me

[malithsen]

Not a fan of this series of inline JS, but I also don't see a significantly better approach compared to this.

[daledupreez]

Can we not add a JS snippet that wraps all of this logic? It feels like manually generating the onclick handling here is going to be really messy to get right in the long run. Also, is it possible for us to keep the href and simply let the onclick trigger the tracking?

[malithsen]

This is working as indicated, my only nitpick is that we are not actually tracking the click in the admin notice button, but the page load it triggers (&highlight=account-details), so page refreshes will count towards it 🤷🏼
~ Diego

Another option to address the original issue that this in-line JS is trying to solve is that we pass in a URL fragment here, and in the frontend record the event if the fragment is present. Once the event is recorded, remove the fragment so that page refreshes don't result in duplicate events.

[wjrosa]

Good point, folks. I refactored it again in b18cc9c, using Malith's suggestion above (thanks!)

[diegocurbelo]

Thanks for the fixes @wjrosa. It's working as expected now!

[daledupreez]

I removed the reconnection logic yesterday in #4730. I think we need to take a step back to assess how and when we show the reconnection notices due to some of the issues we saw in the 10.0.0 release.

[wjrosa]

I removed all code related to the admin notice yesterday. I kept only the code tracking the existing buttons and links. Still, do you want to put this on hold anyway?