Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Pay ECE: Hide settings for legacy checkout #4120

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

annemirasol
Copy link
Contributor

@annemirasol annemirasol commented Mar 20, 2025

Changes proposed in this Pull Request:

Amazon Pay is not available for legacy checkout. This PR adds an extra check so we don't display it in the settings page if legacy checkout is enabled.

Testing instructions

  1. Turn on the Amazon Pay feature flag using the Stripe helper plugin, or by setting _wcstripe_feature_amazon_pay to yes in wp_options.
  2. Enable legacy checkout.
  3. Verify that Amazon Pay is not available under Payment Methods > Express Checkout.
  4. Disable legacy checkout.
  5. Verify that Amazon Pay is available under Payment Methods > Express Checkout.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@annemirasol annemirasol marked this pull request as ready for review March 20, 2025 19:26
@annemirasol annemirasol self-assigned this Mar 20, 2025
@annemirasol annemirasol requested review from a team and malithsen and removed request for a team March 20, 2025 19:35
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good and tests well :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants