-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix payment method name for the pay for order page #4047
Open
wjrosa
wants to merge
49
commits into
develop
Choose a base branch
from
fix/order-pay-for-order-payment-method-name
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/woocommerce/woocommerce-gateway-stripe into add/spe-block-checkout-implementation3
…ub.com/woocommerce/woocommerce-gateway-stripe into add/spe-block-checkout-implementation3
…hub.com/woocommerce/woocommerce-gateway-stripe into add/spe-classic-checkout-implementation
…-pay-for-order-payment-method-name
…-pay-for-order-payment-method-name
Base automatically changed from
add/spe-classic-checkout-implementation
to
develop
March 19, 2025 21:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR fixes the payment method label for orders paid using the Pay for Order page. #4036 broke it with the change to the container title. I am removing the container title to fix the issue, which is not a big deal since we will hide the title and the container borders in #3896
Testing instructions
fix/order-pay-for-order-payment-method-name
)https://dashboard.stripe.com/settings/payment_methods
(labeled "Your configuration")client/classic/upe/payment-processing.js:136
. This is temporary until the parent configuration, labeled WooCommerce Inc., supports all methods by defaultnpm run build:webpack
)_wcstripe_feature_spe
). You can do it by either hardcoding the return value ofis_spe_available
totrue
or by runningnpm run wp option update _wcstripe_feature_spe 'yes'
wp-admin/admin.php?page=wc-settings&tab=checkout§ion=stripe&panel=settings
)Changelog entry
Changelog Entry Comment
Comment
Post merge