-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Pay ECE: fix payment method issues for subscriptions #4008
base: develop
Are you sure you want to change the base?
Conversation
dc56c8f
to
35e792a
Compare
f0ad153
to
822dc7f
Compare
c6e7834
to
49a5b57
Compare
e88bc99
to
fa2e30a
Compare
fa2e30a
to
2978d4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here 👏
Tests well and the code looks great. I left a couple of comments mostly out of curiosity and not expecting changes.
includes/payment-methods/class-wc-stripe-upe-payment-method-amazon-pay.php
Show resolved
Hide resolved
includes/payment-methods/class-wc-stripe-upe-payment-gateway.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest refactor looks great.
✅ Retested subscriptions with Amazon Pay
✅ Smoke tested some flows (Credit card payments, payment method updates)
Part of #3859
Fixes #3937
Fixes #3938
Changes proposed in this Pull Request:
This PR fixes subscription renewal issues for Amazon Pay, by adding logic to save payment method details in the subscription meta, and creating a payment token for the payment method.
Testing instructions
_wcstripe_feature_amazon_pay
toyes
inwp_options
.Changelog entry
Changelog Entry Comment
Comment
Post merge