[WOOMOB-1469] Booking Customer Filter

[hichamboushaba]

WOOMOB-1469

Description

Since Hicham did most of the work, I'm opening this PR to have at least some sort of Customer filter ready until we create new UI for the Bookings with multi-select option.

Test Steps

1. Open the bookings tab
2. Go to All tab
3. Tap on Filters
4. Select Customer
5. Pick a customer
6. Tap Show bookings
7. Confirm the list was filtered

Images/gif

Screen_recording_20251105_134834.mp4

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[dangermattic]

	2 Warnings
⚠️	Class BookingCustomerFilterViewModel is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️	Class CustomerListSelectionViewModel is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	1cd15fb
	Direct Download	woocommerce-wear-prototype-build-pr14834-1cd15fb.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	1cd15fb
	Direct Download	woocommerce-prototype-build-pr14834-1cd15fb.apk

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.26%. Comparing base (00a1930) to head (1cd15fb).
⚠️ Report is 122 commits behind head on trunk.

Files with missing lines	Patch %	Lines
.../filter/customer/BookingCustomerFilterViewModel.kt	0.00%	12 Missing ⚠️
...kings/filter/customer/BookingCustomerFilterPage.kt	0.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #14834      +/-   ##
============================================
- Coverage     38.27%   38.26%   -0.01%     
  Complexity    10117    10117              
============================================
  Files          2140     2142       +2     
  Lines        121101   121124      +23     
  Branches      16599    16603       +4     
============================================
+ Hits          46346    46347       +1     
- Misses        70046    70067      +21     
- Partials       4709     4710       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR refactors the customer selection functionality to be reusable and implements a customer filter for bookings. The changes rename components from order-specific names to generic customer selection names and extract the exit logic to enable different behaviors (navigation vs. callbacks).

Key Changes:

• Renamed OrderCustomerListScreen to CustomerListSelectionScreen for broader reusability
• Made CustomerListSelectionViewModel open and extracted exitWithCustomer method to support customization
• Implemented booking customer filter using the refactored customer selection components

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
strings.xml	Shortened string resource from bookings_filter_customer_name to bookings_filter_customer
OrderCustomerListFragment.kt	Updated to use renamed CustomerListSelectionScreen
CustomerListSelectionViewModel.kt	Made class open and extracted exitWithCustomer method for customization
CustomerListSelectionScreen.kt	Renamed composable and added showToolbar parameter for flexible UI
CustomerListDialogFragment.kt	Updated to use renamed CustomerListSelectionScreen
BookingCustomerFilterViewModel.kt	New ViewModel extending CustomerListSelectionViewModel with callback-based exit
BookingCustomerFilterPage.kt	New composable page for booking customer filter
BookingFilterListUiState.kt	Updated to use new string resource and added missing trailing comma
BookingFilterListScreen.kt	Implemented customer filter page with customer selection logic

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Using a fallback of 0L for a null customerId could lead to incorrect filtering behavior if 0 is a valid customer ID in the system. Consider handling the null case explicitly by either preventing selection when customerId is null, or documenting that 0 represents 'no customer'.

Suggested change

	state.onUpdateFilterOption(
	BookingsFilterOption.Customer(
	customerId = customer.customerId ?: 0L,
	customerName = "${customer.firstName} ${customer.lastName}".trim()
	.ifBlank { customer.email }.orEmpty()
	)
	)
	customer.customerId?.let { id ->
	state.onUpdateFilterOption(
	BookingsFilterOption.Customer(
	customerId = id,
	customerName = "${customer.firstName} ${customer.lastName}".trim()
	.ifBlank { customer.email }.orEmpty()
	)
	)
	}

[irfano]

@AdamGrzybkowski, I think this is a good suggestion. We can commit Copilot’s code suggestion.

[AdamGrzybkowski]

Yes and no, although technically that's possible because the model has a nullable ID, when you look at the code, that should never happen. I will commit it since it won't hurt us.

[irfano]

LGTM! We can add additional features, such as multiple selection, in a separate PR.