Skip to content

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Oct 27, 2025

Closes WOOMOB-1548

Description

This updates the color of the Filters buttons on the Orders and Products screens. The active button color now matches the “+” button used on these screens.

Test Steps

  1. Open the Orders and Products screens.
  2. Test in both light and dark modes.

Images/gif

Before After
Screenshot_20251027_185255
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@irfano irfano added this to the 23.6 milestone Oct 27, 2025
@irfano irfano added category: design Layout and style elements in the UI or user interface, including color and animations. Enhancement labels Oct 27, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 27, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitd035e13
Direct Downloadwoocommerce-wear-prototype-build-pr14832-d035e13.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 27, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitd035e13
Direct Downloadwoocommerce-prototype-build-pr14832-d035e13.apk

@AdamGrzybkowski AdamGrzybkowski self-assigned this Oct 27, 2025
Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Side note - I've noticed the FAB in dark theme has a different content color, not matching the filter button. Not related so I think this would be best in a separate Linear issue?

@irfano
Copy link
Contributor Author

irfano commented Oct 28, 2025

Side note - I've noticed the FAB in dark theme has a different content color, not matching the filter button. Not related so I think this would be best in a separate Linear issue?

I noticed that too but wasn’t sure whether to update it. However, since the background is different now and all other purple buttons use white text, I think you’re right, I’ve updated it in this PR.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.26%. Comparing base (d970832) to head (d035e13).
⚠️ Report is 2 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14832      +/-   ##
============================================
- Coverage     38.27%   38.26%   -0.01%     
+ Complexity    10101    10100       -1     
============================================
  Files          2131     2131              
  Lines        120595   120595              
  Branches      16529    16529              
============================================
- Hits          46153    46150       -3     
- Misses        69766    69768       +2     
- Partials       4676     4677       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@irfano irfano merged commit a469a1f into trunk Oct 28, 2025
17 checks passed
@irfano irfano deleted the issue/WOOMOB-1548-filters-chip-dark-mode-color branch October 28, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: design Layout and style elements in the UI or user interface, including color and animations. Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants