Move Product and Variations sync action into a single class #14831
+207
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinajirka
added
status: do not merge
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the WooPosSyncProductsAction and WooPosSyncVariationsAction classes into a single file by introducing a new WooPosSyncAction wrapper class. The wrapper delegates to the existing actions, which have been moved from separate files into the same file.
- The
WooPosSyncVariationsActionclass is moved from its own file intoWooPosSyncAction.kt - A new
WooPosSyncActionwrapper class is introduced to providesyncProducts()andsyncVariations()methods - All references to the separate action classes are updated to use the new wrapper
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WooPosLocalCatalogSyncRepositoryTest.kt | Updates test mocks and method calls to use the new WooPosSyncAction wrapper class |
| WooPosSyncVariationsAction.kt | Deleted file - variations action moved to WooPosSyncAction.kt |
| WooPosSyncAction.kt | Adds wrapper class and consolidates both products and variations actions into single file |
| WooPosLocalCatalogSyncRepository.kt | Updates constructor and method calls to use the new wrapper class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
malinajirka
commented
Oct 27, 2025
| maxPages = maxPages | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
📓 All the code within this file below this line was copy-pasted from the separate files.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Base automatically changed from
issue/woomob-1589-woo-poslocal-catalog-use-pages-instead-of-offset-for
to
trunk
October 28, 2025 10:31
samiuelson
removed
the
status: do not merge
samiuelson
deleted the
issue/woomob-1334-woo-poslocal-catalog-run-both-products-and-variations-within-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge label - target branch needs to be trunk.
Description
This PR is just preparation for refactoring the WooPosSyncProductsAction and WooPosSyncVariationsAction into a single action. Since moving and refactoring the classes within a single PR could easily get out of hand and would be difficult to review, this PR simply moves the actions into a single file and a shared class.
Test Steps
No need to test anything - it's just a simple move.
Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.