[WOOMOB-1544] Fix POS Local Catalog settings toggle clickable area #14829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the clickable area for the "Manage data usage" toggle in POS Local Catalog settings. Previously, users could only interact with the toggle switch itself; now the entire row is clickable with proper visual feedback.
Key Changes:
- Made the entire row clickable instead of just the switch component
- Added visual feedback with rounded corners and padding
- Disabled direct Switch interaction to prevent double-handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...commerce/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogScreen.kt
Show resolved
Hide resolved
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
samiuelson
deleted the
issue/woomob-1544-woo-poslocal-catalog-local-catalog-settings-toogle-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOMOB-1544
Description
The "Allow full update on cellular data" toggle in POS Local catalog settings was only clickable on the toggle switch itself, not the entire row. This made it difficult for users to interact with the setting as they had to tap precisely on the toggle control.
This PR fixes the issue by making the entire row clickable with proper visual feedback.
Test Steps
Images/gif
Screen.Recording.2025-10-27.at.10.55.42.mov
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.