-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Buildkite] Test Android Staging on ami-0953ca1d949c23a58
-> ami-0f976e0b4de96aa28
#13387
Conversation
AMI Name: android-build-image-6.12.0v1.5-rc-1
FYI: This change is done for testing purposes only, and in order to verify that the newly added 'init.gradle.kts' script is working as expected. A8C CI Toolkit PR: [Dependency Cache] Test Custom Init Gradle Task to Download Dependencies #142 - Automattic/a8c-ci-toolkit-buildkite-plugin#142
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
This custom 'downloadDependencies' task is part of the Android AMI, that is utilized by the 'android' agents, and it is becoming available to all project via the 'init.gradle.kts' script that is included in it.
👋 @wzieba , I just added you as a review on this draft PR, to be closed when we get ready with the new Android AMI, but please, take a look at the description (results). 🙏 TL;DR: Everything is working as expected, a total win, I am happy with the result, with the only drawback that it now takes more time to save and restore the cache.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, during restoring, you add an additional 5s to 10s, which is indeed something we expected, but worth noticing/thinking about anyway. 👀
Yeah, thanks for highlighting this! It's unfortunate and might even change in which jobs we use the dependency cache, but so low cost of maintaining the "save-cache" script across projects is I think worth these 5-10s.
Btw @wzieba , forgot to say that I agree with what you say here, and worse case we could revert back to using the |
A new Android AMI got created that now finalizes 'downloadDependencies' with the 'androidDependencies' task.
ami-0953ca1d949c23a58
ami-0953ca1d949c23a58
-> ami-0f976e0b4de96aa28
Related: a8c-ci-toolkit-buildkite-plugin##142
AMI Name:
android-build-image-6.12.0v1.5-rc-1
Description
This PR changes the Buildkite agent from
android
toandroid-staging
. This change is not meant to be merged, but rather used to verify that the new AMIami-0953ca1d949c23a58
works as expected.Before the Change
Lint
): Build Scan -> Network Activity*12
37
4s
(*) Although, note that these numbers might not be very representative because
trunk
is using a dependency cache that is already outdated (5 days has passed since it was last updated, every Sunday).After the Change
Lint
): Build Scan -> Network Activity0
0
0
Conclusions
As expected, using
./gradlew downloadDependencies androidDependencies
is:save-cache.sh
script as the project evolves.+ 321.34 MB
more data downloaded, which means even less network requests on CI.+ 29 seconds
to save the cache.+ 5 seconds
to restore the cache.