Skip to content

tests: add service file test pipeline and use it in in a few packages #48686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

justinvreeland
Copy link
Member

@justinvreeland justinvreeland commented Mar 31, 2025

The tar lines, while I don't like fix an issues that systemd-analyze
verify found where symlinks are turned into real files. Test was moved
forward in the pipeline because we don't have install via file lists
and otherwise other packages will pickup the test files when they shoulnd't.

All the service files aren't 100% clean but they're not longer failing.

This should probably also have a warning linter like ldd or docs do.

@justinvreeland justinvreeland force-pushed the jvreeland/analyze-services branch from 938c759 to 01741e3 Compare March 31, 2025 19:09
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Mar 31, 2025
@justinvreeland justinvreeland marked this pull request as ready for review March 31, 2025 20:40
@justinvreeland justinvreeland requested a review from a team as a code owner March 31, 2025 20:40
@justinvreeland
Copy link
Member Author

huh, compression is probably a waste of resources since I just want it to track the links and attrs for me.

Copy link
Member

@a-crate a-crate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to optionally install -doc or -docs and enable man checking if those exist but I think that would require melange changes to do in a clean way.

@justinvreeland
Copy link
Member Author

It would be nice to optionally install -doc or -docs and enable man checking if those exist but I think that would require melange changes to do in a clean way.

Ohhh that I wanted those tests to run but forgot I could just install packages.

This should be doable by taking another input variable. We can then pop the tests on the package with withdocs: true and then install the packages that have the service file as part of the environment for the docs tests. Could probably even check if the name of the package is doc and then enable the flag and assume the tester added the packages with the service files to the environment. Failure on empty helps there as well in case you installed no service files in the doc env. Not as idea as a system where melange can manage it all but should be doable.

@justinvreeland justinvreeland force-pushed the jvreeland/analyze-services branch from 01741e3 to f14f027 Compare April 1, 2025 00:30
@justinvreeland justinvreeland requested a review from a-crate April 1, 2025 00:31
@justinvreeland justinvreeland force-pushed the jvreeland/analyze-services branch from f14f027 to b92a1b0 Compare April 1, 2025 02:29
The tar lines, while I don't lile fix an issues that systemd-analyze
verify found where symlinks are turned into real files. Test was moved
forward in the pipeline because we don't have install via file lists
and otherwise other packages will pickup the test files when they shoulnd't.

All the service files aren't 100% clean but they're not longer failing.
@justinvreeland justinvreeland force-pushed the jvreeland/analyze-services branch from b92a1b0 to d571789 Compare April 1, 2025 02:43
@justinvreeland justinvreeland merged commit 7c296b0 into wolfi-dev:main Apr 1, 2025
15 checks passed
MickeyPvX pushed a commit to MickeyPvX/wolfi-dev-os that referenced this pull request Apr 1, 2025
…wolfi-dev#48686)

The tar lines, while I don't like fix an issues that systemd-analyze
verify found where symlinks are turned into real files. Test was moved
forward in the pipeline because we don't have install via file lists
and otherwise other packages will pickup the test files when they
shoulnd't.
    
All the service files aren't 100% clean but they're not longer failing.

This should probably also have a warning linter like ldd or docs do.

Co-authored-by: Justin Vreeland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants