Free WOLFSSL_X509 from wolfSSL_get_peer_certificate() with wolfSSL >= 5.3.0 #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with wolfSSL 5.3.0 (wolfSSL/wolfssl@afca455), the
wolfSSL_get_peer_certificate()
API returns a new/duplicateWOLFSSL_X509
structure that needs to be explicitly freed withwolfSSL_X509_free()
.Prior to wolfSSL 5.3.0,
wolfSSL_get_peer_certificate()
returned a pointer to internal memory that was freed automatically by normal native wolfSSL cleanup routines.This shows up through some exploration with
-fsanitize=address
: