20250228-fixes #8522
Merged
20250228-fixes #8522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix gating (OPENSSL_EXTRA, not OPENSSL_ALL) in FreeSuites() re .suitesStack and .clSuitesStack, and similarly fix gating on the implementation of wolfSSL_sk_SSL_CIPHER_free(() and related. src/ssl_sess: suppress false positive clang-analyzer-unix.Malloc "Argument to 'free()' is the address of a global variable".
…l declarations to avoid shadowing global functions, for the convenience of obsolete (pre-4v8) gcc -Wshadow.
ribes96
reviewed
Mar 1, 2025
dgarske
previously approved these changes
Mar 1, 2025
|
retest this please (script timeout and |
dgarske
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/ssl.c, src/internal.c: fix leak inwolfSSL_get_ciphers_compat(): fix gating (OPENSSL_EXTRA, notOPENSSL_ALL) inFreeSuites()re.suitesStackand.clSuitesStack, and similarly fix gating on the implementation ofwolfSSL_sk_SSL_CIPHER_free()and related.src/ssl_sess: suppress false positiveclang-analyzer-unix.Malloc"Argument to 'free()' is the address of a global variable".wolfcrypt/src/sp_int.c,src/ssl_asn1.c,src/internal.c: rename several declarations to avoid shadowing global functions, for the convenience of obsolete (pre-4v8) gcc-Wshadow.tests/api.c: disabletest_wolfSSL_OCSP_parse_url()ifWOLFSSL_SM2||WOLFSSL_SM3..wolfssl_known_macro_extras: remove unneeded entries.tested with various
wolfssl-multi-test.shscenarios that were failing in the nightlies without these fixes.