Fix compat layer ASN1_TIME_diff to accept NULL output params #8407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first two parameters to
ASN1_TIME_diff()
areint *pday
andint *psec
. These refer to the locations where output values of days and seconds are to be written. OpenSSL 1.0.2 and 1.1.1 accept NULL values for either pday, psec or both, always returning success/1 in these cases.Fix in the equivalent wolfSSL function,
wolfSSL_ASN_TIME_diff()
to not require pday or psec to be non-NULL.Fixes zd19346
Testing
Updated unit tests
Checklist