Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat layer ASN1_TIME_diff to accept NULL output params #8407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

embhorn
Copy link
Member

@embhorn embhorn commented Jan 31, 2025

Description

The first two parameters to ASN1_TIME_diff() are int *pday and int *psec. These refer to the locations where output values of days and seconds are to be written. OpenSSL 1.0.2 and 1.1.1 accept NULL values for either pday, psec or both, always returning success/1 in these cases.

Fix in the equivalent wolfSSL function, wolfSSL_ASN_TIME_diff() to not require pday or psec to be non-NULL.

Fixes zd19346

Testing

Updated unit tests

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@embhorn embhorn requested a review from julek-wolfssl January 31, 2025 21:59
@embhorn embhorn self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant