Skip to content

adjust highwater check location to avoid masking return value #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JacobBarthelmeh
Copy link
Contributor

ZD19648

@JacobBarthelmeh JacobBarthelmeh self-assigned this Apr 4, 2025
@JacobBarthelmeh JacobBarthelmeh requested a review from Copilot April 4, 2025 20:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/internal.c:10035

  • [nitpick] The log message 'PR: HighwaterCheck fail' is unclear. It is recommended to update the log message to provide more descriptive information about the highwater check failure.
WLOG(WS_LOG_DEBUG, "PR: HighwaterCheck fail");

@JacobBarthelmeh JacobBarthelmeh changed the title do highwater check at the end of processing a packet adjust highwater check location to avoid masking return value Apr 8, 2025
@JacobBarthelmeh
Copy link
Contributor Author

Working on a unit test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants