microchip example and filesystem port #790
Merged
+22,844
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
force-pushed
the
pic32
branch
14 times, most recently
from
e4a0784 to
71911fa
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for MICROCHIP MPLAB Harmony along with a filesystem port for wolfSSH. Key changes include:
- Enabling WOLFSSH_STOREHANDLE and related configuration for MICROCHIP_MPLAB_HARMONY.
- Adding new filesystem function implementations (wfopen, wPread, wPwrite, and wChmod) to support Harmony.
- Updating SFTP functionality and logging across various source files.
Reviewed Changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfssh/settings.h | Added conditional definition of WOLFSSH_STOREHANDLE |
| wolfssh/port.h | Introduced Harmony-specific filesystem macros and function declarations |
| wolfssh/internal.h | Updated MAX_HMAC_SZ definition |
| src/wolfsftp.c | Added logging for file open modes and Harmony-specific SFTP handling |
| src/ssh.c | Adapted key file reading for Harmony |
| src/port.c | Implemented Harmony-specific wfopen, wPread, wPwrite, and wChmod |
| src/io.c | Added Harmony-specific checks for TCP/IP connection status |
| src/internal.c | Minor cleanups with WOLFSSH_UNUSED to avoid warnings |
| ide/mplabx/* | Updated configuration and documentation files for MPLABX projects |
Files not reviewed (4)
- ide/include.am: Language not supported
- ide/mplabx/include.am: Language not supported
- ide/mplabx/wolfssh.X/Makefile: Language not supported
- ide/mplabx/wolfssh.X/nbproject/project.xml: Language not supported
dgarske
requested changes
Apr 3, 2025
dgarske
approved these changes
Apr 3, 2025
dgarske
requested changes
Apr 3, 2025
dgarske
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.