RFC-4256 Keyboard-Interactive authentication #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinuxJedi
force-pushed
the
RFC-4256
branch
5 times, most recently
from
bab5784 to
9e7bd3f
Compare
LinuxJedi
force-pushed
the
RFC-4256
branch
3 times, most recently
from
d385689 to
8d1a669
Compare
LinuxJedi
force-pushed
the
RFC-4256
branch
5 times, most recently
from
5f68a6c to
4f65c0b
Compare
|
Added additional packet checks and an additional test. |
LinuxJedi
force-pushed
the
RFC-4256
branch
2 times, most recently
from
8ee69de to
de0f986
Compare
LinuxJedi
force-pushed
the
RFC-4256
branch
2 times, most recently
from
fbef091 to
7ea9f8f
Compare
ejohnstown
requested changes
Feb 6, 2025
src/internal.c
Outdated
| if (ssh == NULL || output == NULL || idx == NULL || authData == NULL) | ||
| ret = WS_BAD_ARGUMENT; | ||
|
|
||
| if (authData->sf.keyboard.promptCount != authData->sf.keyboard.responseCount) { |
There was a problem hiding this comment.
If authData is NULL, ret is set to the error code, but we'll still dereference it here.
There was a problem hiding this comment.
Good catch. I ran my work from #769 and found another one too. Both fixed.
src/internal.c
Outdated
| @@ -7526,6 +7685,10 @@ static int DoUserAuthFailure(WOLFSSH* ssh, | |||
| ret = SendUserAuthRequest(ssh, authType, 0); | |||
| } | |||
|
|
|||
| if ((ret == WS_SUCCESS) && (authType & WOLFSSH_USERAUTH_KEYBOARD)) { | |||
| //ret = SendUserAuthKeyboard(ssh, authType); | |||
There was a problem hiding this comment.
Please don't use C++ comments.
There was a problem hiding this comment.
Doh! That shouldn't be there at all, I thought I had removed it already.
This implements Keyboard-Interactive authentication. Adds an additional callback set by `wolfSSH_KeyboarAuthPrompts()` which will set a callback in the server to ask the application to provide the prompt details for the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Keyboard-Interactive authentication.
Adds an additional callback set by
wolfSSH_KeyboarAuthPrompts()which will set a callback in the server to ask the application to provide the prompt details for the client.