load server-side key via CLI #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbrett
force-pushed
the
wolfBoot-sim-server
branch
from
336bed0 to
3024e76
Compare
|
@billphipps ug, needs your fixes in #15 to get merged first, otherwise will keep failing CI |
billphipps
approved these changes
Oct 14, 2024
|
|
||
| static int wh_ServerTask(void* cf) | ||
| static int loadAndStoreKeys(whServerContext* server, whKeyId* outKeyId, |
There was a problem hiding this comment.
Suggested change
| static int loadAndStoreKeys(whServerContext* server, whKeyId* outKeyId, | |
| static int _LoadAndStoreKeys(whServerContext* server, whKeyId* outKeyId, |
Been trying to make all static functions start with _
| int ret; | ||
| int keyFd; | ||
| int keySz; | ||
| char keyLabel[] = "baby's first key"; |
There was a problem hiding this comment.
Maybe consider using basename(keyFilePath) for the label?
| #define WOLFHSM_CFG_SERVER_DMAADDR_COUNT 8 | ||
| #define WOLFHSM_CFG_SERVER_CUSTOMCB_COUNT 8 | ||
|
|
||
| #define XMEMFENCE() __atomic_thread_fence(__ATOMIC_SEQ_CST) |
There was a problem hiding this comment.
Are you sure you need this override for the example? I think the autodetect logic should pick the right one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--keyand--idCLI arguments. Required for wolfBoot simulator supportwhile(1)and reinitializes the server context on client disconnect