Fix potential OOB-read in delta diff#719
Merged
dgarske merged 3 commits intowolfSSL:masterfrom Mar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a potential out-of-bounds read in wb_diff() when extending matches to the end of the input buffers, and adds unit tests to reproduce those edge cases. Also includes a small macro correctness tweak.
Changes:
- Add bounds checks in
wb_diff()match-extension loops to prevent OOB reads. - Add new unit tests covering “match extends to end of src_b” scenarios.
- Fix a macro precedence issue by adding missing parentheses.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tools/unit-tests/unit-delta.c | Adds regression tests for the OOB scenario; refactors buffer initialization helper. |
| src/delta.c | Adds bounds checks to prevent match-extension loops from reading past buffer ends. |
| src/libwolfboot.c | Wraps a macro expression in parentheses to avoid precedence issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F/434 - potential out-of-bounds read while creating the patch
Also includes minor unrelated fix:
F/436: Added missing parenthesis around macro