Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: removeListener sometimes not working #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug: removeListener sometimes not working #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/element-resize-detector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,18 @@ module.exports = function(options) {
//The element is not prepared to be detectable, so do prepare it and add a listener to it.
elementUtils.markBusy(element, true);
return detectionStrategy.makeDetectable({ debug: debug, important: importantCssRules }, element, function onElementDetectable(element) {

// If the element or its parent has already been removed and appended to the DOM again
// then Object.onload is been called again, and this function will be called again
// such as keep-alive in vue;
// so we need to avoid calling this function again
// in some scenarios: users want to removeListener before element been removed
// but when the element been appended to the DOM again, if this function is called
// then addListener function will be called again
if(elementUtils.isDetectable(element)) {
return
}

debug && reporter.log(id, "onElementDetectable");

if (stateHandler.getState(element)) {
Expand Down