Display lock screen popups #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that tooltips (and context menus) show up when using this branch. On a personal level I am not that interested in lock-screens but having the session-lock implementation in gtk4-layer-shell should allow to build relatively fancy ones for people interested. And for anything fancy, tooltips and context menus sound like a good thing to support. So the approach of using subsurfaces makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains what I've got so far for showing popups (and maybe in the future toplevels) on the lock screen. It kinda works now, but isn't production-ready (popups aren't placed correctly, and it's not well tested) so I didn't put it in v1.1.0. I may work on this soon or let it sit for a while. Let me know if popups not showing up is causing you a problem.