Skip to content

fix white channel for "Rainbow" effect #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chschu wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix white channel for "Rainbow" effect #5694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
105f427
clear garbage white value in hsv2rgb_rainbow, overwrite white value i…
chschu Jun 21, 2026
512a68e
revert change in hsv2rgb_rainbow
chschu Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions wled00/FX_fcn.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,10 +1148,10 @@ void Segment::blur(uint8_t blur_amount, bool smear) const {
*/
uint32_t Segment::color_wheel(uint8_t pos) const {
if (palette) return color_from_palette(pos, false, true, 0); // color_wheel is a continuous (moving) wheel, so wrap end->start (restores pre-0.16 behaviour)
uint8_t w = W(getCurrentColor(0));
CRGBW rgb;
rgb = CHSV32(static_cast<uint16_t>(pos << 8), 255, 255);
return rgb.color32 | (w << 24); // add white channel
rgb.w = W(getCurrentColor(0)); // add white channel

@DedeHai DedeHai Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, thanks for uncovering this. we changed this function a few times over so something must have gotten lost somewhere along the way.

return rgb.color32;
}

/*
Expand Down
Loading