Closed
Conversation
Test refaactor
Test refaactor
- Add gridlights-build.yml GitHub Actions workflow that builds esp32dev on every push and pull request, with pip/platformio/.pio caching - Add platformio_override.ini with GridLights hardware defaults: LED pin 4, 37x SK6812 RGBW, relay pin 5 (active low) - Remove platformio_override.ini from .gitignore so board config is shared Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaced by gridlights-build.yml which uses non-deprecated action versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Allows manual runs from the GitHub Actions tab. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The .bin lives at .pio/build/<env>/firmware.bin, not build_output/. Also set if-no-files-found to error so a missing binary fails the build. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bah, aHourglass, AlmostNuke, aNuke)
- Added 35 new effects in 7 families, each at 3/6/9/12/20 Hz variants
- Mode IDs 214-248, MODE_COUNT updated to 249
- Fixed Frame struct initializers from {data,60,N} to {data,37,1,60,N,255}
- Added missing aSidewaysMerkabah3 implementation
- Fixed duplicate aSidewaysMerkabah6 addEffect registration
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds GRIDLIGHTS_VERSION build flag (2.2.1) to platformio_override.ini and exposes it as gl_ver in the serializeInfo() response, distinct from the base WLED ver field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fails any pull request targeting main where GRIDLIGHTS_VERSION in platformio_override.ini has not been incremented relative to main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Caution Review failedPull request was closed or merged during review WalkthroughIntroduces the GridLights project infrastructure with automated build and version-check GitHub Actions workflows, adds 62 new FX effect modes with a frame-based rendering framework to FX.cpp, increases frame rate from 42 to 100 FPS, and adds GridLights-specific configuration via platformio_override.ini while removing DNS captive portal functionality. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit