Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for compiling with cmake generated Xcode project #220

Closed
wants to merge 2 commits into from
Closed

fixes for compiling with cmake generated Xcode project #220

wants to merge 2 commits into from

Conversation

AndySomogyi
Copy link

Hi,

I added a few fixes that enables compilation of nanogui with CMake generated Xcode projects. Xcode has a bug, and I've implemented the CMake suggested work around.

I've verified that this fix works for both Xcode generated projects, and CMake generated makefiles.

@AndySomogyi AndySomogyi reopened this May 16, 2017
@AndySomogyi
Copy link
Author

Hi,

looks like something strange is going on with the Travis CI, as the nanogui CMakeLists.txt has required CMake version 2.8.12 for some time, but for some reason, the host operating system seems to have been downgraded to version 2.8.7.

Output from Travis CI on the gcc 4.8 test:
CMake 2.8.12 or higher is required. You are running version 2.8.7

@wjakob
Copy link
Owner

wjakob commented Oct 4, 2017

Apologies for the big delay. Two issue that I see with the PR are

  1. It fails the CI tests (probably easily fixable by rebasing)
  2. It hacks the STB implementation exports to across the platforms, rather than switching to a uniform scheme. What would have made much more sense to me is to ensure that the symbols are exported on all platforms, and then import them consistently.

Items #1 and #2 are really independent from each other. For that reason, it may be easier to split this into two separate PRs.

Thanks,
Wenzel

@svenevs
Copy link
Collaborator

svenevs commented Oct 4, 2017

The Travis builds failed because this was submitted before #224. If you close and reopen the PR that will relaunch Travis.

svenevs added a commit to svenevs/nanogui that referenced this pull request Jan 27, 2018
- Revives original solution proposed in wjakob#220
- Adds exclusion of GLFW library, XCode fails to link this
@svenevs svenevs mentioned this pull request Jan 27, 2018
wjakob pushed a commit that referenced this pull request Jan 27, 2018
- Revives original solution proposed in #220
- Adds exclusion of GLFW library, XCode fails to link this
wjakob referenced this pull request in mitsuba-renderer/nanogui Mar 6, 2018
- Revives original solution proposed in #220
- Adds exclusion of GLFW library, XCode fails to link this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants