fix: android potential crashes, java.lang.RuntimeException: Tried to create view after it has already been destroyed #8052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened?
The app crashes unexpectedly when upgraded from 7.41.1 to 7.44.0.
What was the expected behavior?
The app should not crash.
Was it tested on the latest react-native-navigation?
I have tested this issue on the latest react-native-navigation release and it still reproduces.
Root Cause
Production crashes occurred after refactoring the status bar logic from Java
Presenter.java
to KotlinStatusBarPresenter.kt
. The issue stems from how Kotlin handles theviewController.view
property:Previous behavior (Java): Direct field access
ViewController.view
worked without checks.Current behavior (Kotlin):
viewController.view
callsgetView()
, which checks if the view is destroyed. If the view is already destroyed, this check throws an exception, causing crashes.In what environment did this happen?
React Native Navigation version: since 7.44.0
React Native version: -
Has Fabric (React Native's new rendering system) enabled: true
Node version: -
Device model: -
Android version: -