Debug config validate#238
Conversation
Generated
|
|
I think it's important we don't build that as part of the library. |
…debug_config_validate
…debug_config_validate
| trigger: z.enum(['viewEnter', 'pageVisible']), | ||
| params: ViewEnterParams.optional(), |
There was a problem hiding this comment.
pageVisible, besides being Wix-only, is a wrapper above viewEnter + triggerType: 'state', which is now on the effect. It's becoming somewhat problematic to keep.
There was a problem hiding this comment.
oh I missed it because it is not really documented anywhere that it must have triggerType: 'state' - I guess that it is another strong indication to remove it. Maybe we can also make sure that wix do the transformation from pageVisible to viewEnter + triggerType: 'state' and pass a valid config to Interact
| result.sort((a, b) => { | ||
| const pa = a.path.join('\0'); | ||
| const pb = b.path.join('\0'); | ||
| return pa < pb ? -1 : pa > pb ? 1 : 0; |
There was a problem hiding this comment.
What are we comparing here? Length of string? Or do these strings represent numbers?
There was a problem hiding this comment.
I think it is lexical order on strings that represent paths in the config - does not seem ideal, should fix that
Description
Related Issue
Checklist
Screenshots / Demos
Additional Notes