Skip to content

feat(v7): stabilize advanced routing#13983

Merged
matthewp merged 22 commits into
v7from
armand/stable-advanced-routing
Jun 9, 2026
Merged

feat(v7): stabilize advanced routing#13983
matthewp merged 22 commits into
v7from
armand/stable-advanced-routing

Conversation

@ArmandPhilippot

@ArmandPhilippot ArmandPhilippot commented Jun 3, 2026

Copy link
Copy Markdown
Member

Description (required)

Updates docs to stabilize advanced routing. Kinda supersedes #13944

  • Cherry-picks changes made in Update v7 upgrade guide changes #13944 to the v7 upgrade guide and the src/app.ts renaming
  • Moves experimental-flags/advanced-routing contents to references/modules/astro-fetch.mdx (new), references/modules/astro-hono.mdx (new), guides/routing.mdx, and /en/guides/integrations-guide/cloudflare.mdx.
  • Updates the sidebar to remove/add pages
  • Removes the experimental-flags/advanced-routing translations
  • Adds a redirection

Most of the content comes from experimental-flags/advanced-routing. But I have tweaked/reworded/reorganized some parts for better integration (ie. a more guide/reference style).

Happy to discuss about the organization (e.g. do we want advanced routing to be more visible?). And maybe this requires more changes, I haven't checked everything yet (e.g. Routing reference says "There is no separate routing configuration in Astro." which sounds maybe a bit outdated now).

Questions:

  • Should AstroFetchState be documented? I can see this is the public contract / this matches what we describe under FetchState. But doing const state = new FetchState(); returns FetchState (the whole object, with private things) not AstroFetchState. So, I'm not sure how to integrate that.

Related issues & labels (optional)

  • Suggested label: 7.0

For Astro version: 7.0. See astro PR #16877.

@ArmandPhilippot ArmandPhilippot added this to the v7 milestone Jun 3, 2026
@ArmandPhilippot ArmandPhilippot added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) 7.0 labels Jun 3, 2026
@netlify

netlify Bot commented Jun 3, 2026

Copy link
Copy Markdown

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 796df05
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6a28400f606cdf0008a04701
😎 Deploy Preview https://deploy-preview-13983--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 3, 2026
@astrobot-houston

astrobot-houston commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/integrations-guide/cloudflare.mdx Source changed, localizations will be marked as outdated.
en/guides/routing.mdx Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v7.mdx Localization changed, will be marked as complete.
en/reference/experimental-flags/advanced-routing.mdx Source removed, will stop being tracked.
en/reference/modules/astro-fetch.mdx Localization added, will be marked as complete.
en/reference/modules/astro-hono.mdx Localization added, will be marked as complete.
fr/reference/experimental-flags/advanced-routing.mdx Localization removed, will be marked as missing.
ko/reference/experimental-flags/advanced-routing.mdx Localization removed, will be marked as missing.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ArmandPhilippot ArmandPhilippot marked this pull request as ready for review June 4, 2026 17:27
Comment thread src/content/docs/en/reference/modules/astro-hono.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v7.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v7.mdx Outdated
@ArmandPhilippot

Copy link
Copy Markdown
Member Author

Thanks @matthewp, done in f60c839!

Reposting my only doubt here:

Should AstroFetchState be documented? I can see this is the public contract / this matches what we describe under FetchState. But doing const state = new FetchState(); returns FetchState (the whole object, with private things) not AstroFetchState. So, I'm not sure how to integrate that.

What do you think about AstroFetchState? Currently, I'm not sure this is helpful in docs, but since this is the public contract (and is importable), I thought it might be useful to mention it.

I mean, when using new FetchState() (at least with the v6 implementation, I haven't checked with your branch), it returns everything and AstroFetchState is never mentioned:

image

Comment thread src/content/docs/en/guides/routing.mdx Outdated
@matthewp

matthewp commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

We shouldn't document AstroFetchState, that only exists for types. From the user's perspective it's just the FetchState object.

@matthewp

matthewp commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Changes to the upgrade guide look great, thanks!

@matthewp matthewp merged commit 139edaa into v7 Jun 9, 2026
8 checks passed
@matthewp matthewp deleted the armand/stable-advanced-routing branch June 9, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.0 i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants