-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: fonts csp #12103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: fonts csp #12103
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Florian! Just a couple of quick initial questions here to start!
<p> | ||
|
||
**Type:** `string[]`<br /> | ||
**Default:** `[]`<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we run into a similar tricky situation documenting something not too long ago where adding any value overrides (and removes) the default that needs to be added back in? 😅 What was that and how did we handle that?
I think what feels off here is that if you do nothing, by default you get the same result as if you added this property with 'self'
, right? So it's kind of like the default value is 'self'
and not nothing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! FYI I just copied the other properties so they would also need to be updated
**Default:** `[]`<br /> | |
**Default:** `["'self'"]`<br /> |
<meta | ||
http-equiv="content-security-policy" | ||
content=" | ||
font-src https://fonts.cdn.example.com; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the same situation where doing this overrides and removes 'self'
? If so, feels like that should also be mentioned, since it will remove the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it's merged with the config so we could show 'self'
if we wanted. Maybe @ematipico has an opinion on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so if this merges that's probably easier to document! We would just make sure that we describe it as "additive"
Description (required)
Document new APIs that allow fonts to work with csp
Related issues & labels (optional)
For Astro version:
???
. See astro PR #14154.(Doesn't require a minor, but won't be ready for 5.13.0 so will release sometime after)