fix: outputs and type in astro-i18n
#10797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArmandPhilippot
added
typo/link/grammar - quick fix!
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
approved these changes
Jan 27, 2025
|
Ah yes your list is much shorter during the T&D... Well, it wasn't urgent the doc has been like this for a while! 😄 |
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Jan 28, 2025
ArmandPhilippot
pushed a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
getRelativeLocaleUrl("fr")andgetAbsoluteLocaleUrl("fr")(missing slash)getAbsoluteLocaleUrl()(path is optional)Related issues & labels (optional)
getRelativeLocaleUrl/getAbsoluteLocaleUrlwith empty path appends trailing slash #10743getRelativeLocaleUrlapends trailing slash even withtrailingSlash: 'never'astro#13032code snippet update(and not sure which label matches the type update...typo/link/grammar - quick fix!I guess) ... Feel free to correct the labels 😄