-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fonts): experimental release #12775
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3fcdba0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
CodSpeed Performance ReportMerging #12775 will not alter performanceComparing Summary
|
* feat(fonts): work on local provider * feat: config, types and options * feat: dedupe * feat: todo * chore: clean * feat: rework local provider * feat: work on local provider * fix: storage * fix: types * Discard changes to examples/basics/astro.config.mjs * Discard changes to examples/basics/src/components/Welcome.astro * Discard changes to examples/basics/src/layouts/Layout.astro * chore: clean * chore: comment * feat: dedupe
* feat(fonts): improve providers * feat: export defineFontProvider * feat: type test * feat: test providers * feat: test providers utils * feat: more tests * fix: path
* feat(fonts): fallbacks * feat: local * fix: test * feat: isGenericFontFamily test * feat: generateFallbackCSS test * feat: docs * feat: simplify * fix * feat: improve schema * Discard changes to examples/basics/astro.config.mjs * feat: address reviews
* feat: improve loop * feat: simplify cache * feat: extract initialize logic * fix: circular dependency * fix: circular dependency * feat: test * chore: remove comment * feat: address reviews * chore: logs * fix: normalize path * test * chore: remove logs
* feat(fonts): css vars * feat: tests and fix * chore: add todos
* feat(fonts): as prop * chore: comment
* feat(fonts): resolve config todos * feat: work on schemas * fix: local provider * feat: local provider test * feat: schemas tests * feat: config tests * feat: load test * fix: types tests * feat: address reviews
* feat(fonts): use capsize instead of fontaine * fix: tests * feat: extract regex to constant
* feat(fonts): add errors * feat: component errors * fix: error * fix: tests * Update packages/astro/src/core/errors/errors-data.ts Co-authored-by: Sarah Rainsberger <[email protected]> * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <[email protected]> * feat: address reviews * Update packages/astro/src/core/errors/errors-data.ts Co-authored-by: Sarah Rainsberger <[email protected]> * feat: improve errors --------- Co-authored-by: Sarah Rainsberger <[email protected]>
* feat(fonts): typegen for <Font /> family prop * feat: add internal jsdoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the error messages as I'm not sure there's anything else in here for me right now.
(The changeset will be the last thing, when we're ready to H.Y.P.E.!)
Co-authored-by: Sarah Rainsberger <[email protected]>
astro
@astrojs/cloudflare
@astrojs/netlify
@astrojs/node
@astrojs/vercel
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing these errors out! Left some thoughts for you! 🙌
API bash
Thanks for trying the experimental fonts API. Here's how to get set up.
Helpful resources
Setup
Create a project as normal, or use an existing one:
Install the experimental
astro
release:Configure fonts:
Usage
Use the Font component and the generated CSS variable:
What to test
Changes
Testing
Manual and automated
Docs