-
Notifications
You must be signed in to change notification settings - Fork 59
[1.21.10] Configuration API Overhaul #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.21.9
Are you sure you want to change the base?
[1.21.10] Configuration API Overhaul #417
Conversation
- More supported types - Better config Sync - Server Config Management - Ability to handle more than one config instance - Slider Adjustments from Chyz - Adjust how section headers are on the side - Ability to switch between config instances - Simple utility to copy translation key for missing translation in config - Rework underling code to handle other types of objects and give better access to customize certain option calls without reflection # Conflicts: # src/main/java/io/wispforest/owo/Owo.java # src/main/java/io/wispforest/owo/client/OwoClient.java # src/main/java/io/wispforest/owo/config/ConfigWrapper.java # src/main/java/io/wispforest/owo/config/ui/ConfigScreen.java # src/main/java/io/wispforest/owo/config/ui/ConfigScreenProviders.java # src/main/java/io/wispforest/owo/ui/base/BaseParentComponent.java # src/main/java/io/wispforest/owo/ui/component/LabelComponent.java # src/main/java/io/wispforest/owo/ui/container/Containers.java # src/main/java/io/wispforest/owo/ui/container/ScrollContainer.java # src/main/java/io/wispforest/owo/ui/core/OwoUIDrawContext.java # src/main/java/io/wispforest/owo/ui/core/Surface.java # src/main/java/io/wispforest/owo/ui/util/MatrixStackTransformer.java # src/main/resources/owo.accesswidener # src/testmod/java/io/wispforest/uwu/client/SelectUwuScreenScreen.java
…ead only on initial creation
…tation access - Update Config Constraints to allow for different ones for input and apply - Add proper way of dumping translation data using `ConfigTranslationHelper` - Rework option annotation access around `AnnotatedElement`
…a `ToggleButton` � Conflicts: � src/main/java/io/wispforest/owo/ui/component/ButtonComponent.java � src/main/java/io/wispforest/owo/ui/core/OwoUIDrawContext.java
…after screen build
|
Despite missing the last task (Make custom font for better looking clipboard), do you think this is ready for review? Might make the overall review process faster in case changes are needed |
Overall, it's ready for initial reviews by people, as the reason for it being a draft is that when I opened the PR, I still needed to add some changes. I also planned to wait for glisco to do an initial review of the changes, as I felt they may have some issues with the changes. |
- Adjust Constraints to have a type to indicate to users of the API what each predicate is used for - Switch to only using endec for serialization and abstracting serialization of the given config wrapper to a ConfigSerializer allowing for other formats than just Jankson - Update ModMenu annoation to use the modid of the config wrapper annotation - Cleanup predicate handling for OptionComponents and use more statically defined methods - Refactor location of code and remove commented out code combined with making code prettyer
Primarly this PR attempts to resolve various pain points found or head of when working with owo-config:
Supported Types: