Skip to content

fix: error message not visible when trying to record audio during cal… #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sbakhtiarov
Copy link
Contributor

https://wearezeta.atlassian.net/browse/WPB-12178

What's new in this PR?

Issues

Recording an audio message is not allowed when there is an ongoing call. There are issues with showing the error message to the user.

  • Snackbar message is not visible / partially visible
  • Error is shown when trying to record the audio message. According to the design the app should show the error when user selects "Audio" from attachment options.

Solutions

  • Observe ongoing calls and add isCallOngoing property to the MessageComposerViewState
  • Show toast message (guaranteed to be displayed on top of all views) when "Audio" is selected in attachment options and isCallOngoing == true

Copy link

Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.91%. Comparing base (1941324) to head (494b6a2).

Files with missing lines Patch % Lines
...conversations/composer/MessageComposerViewModel.kt 87.50% 1 Missing ⚠️
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4043      +/-   ##
===========================================
+ Coverage    45.90%   45.91%   +0.01%     
===========================================
  Files          521      521              
  Lines        18187    18197      +10     
  Branches      3068     3068              
===========================================
+ Hits          8348     8356       +8     
- Misses        8974     8976       +2     
  Partials       865      865              
Files with missing lines Coverage Δ
.../ui/home/conversations/MessageComposerViewState.kt 85.71% <100.00%> (+0.42%) ⬆️
...conversations/composer/MessageComposerViewModel.kt 72.82% <87.50%> (+1.39%) ⬆️
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1941324...494b6a2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Built wire-android-staging-compat-pr-4043.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4043.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants