fix: not federating error missing when creating new conversation [WPB-16880] #4042
+21
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Dialog informing about federation error about conflicting backends is not displayed when creating new conversation.
Causes (Optional)
Due to some changes in kalium, the use case doesn’t return proper failure but completes successfully with adding system message informing that some users couldn’t be added.
Solutions
Update kalium version to use the fix. Additionally, change the way domains are presented on the dialog so that it matches other system messages/dialogs and fix the navigation when user clicks “Edit Participants List” - open proper screen where the user chooses participants instead of opening the initial new conversation flow screen.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Try to create a conversation selecting people whose backends do not federate with each other.
Attachments (Optional)
federation-failure-before.mp4
federation-failure-after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.