Skip to content

fix: not federating error missing when creating new conversation [WPB-16880] #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 28, 2025

BugWPB-16880 [Android] No alert displayed when user is trying to create a group with 2 users, who don't federat with each other


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Dialog informing about federation error about conflicting backends is not displayed when creating new conversation.

Causes (Optional)

Due to some changes in kalium, the use case doesn’t return proper failure but completes successfully with adding system message informing that some users couldn’t be added.

Solutions

Update kalium version to use the fix. Additionally, change the way domains are presented on the dialog so that it matches other system messages/dialogs and fix the navigation when user clicks “Edit Participants List” - open proper screen where the user chooses participants instead of opening the initial new conversation flow screen.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

How to Test

Try to create a conversation selecting people whose backends do not federate with each other.

Attachments (Optional)

Before After
federation-failure-before.mp4
federation-failure-after.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, yamilmedina, alexandreferris and MohamadJaara and removed request for a team May 28, 2025 07:57
@saleniuk saleniuk requested review from vitorhugods and ohassine May 28, 2025 07:57
Copy link

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.90%. Comparing base (1941324) to head (597fc2b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4042   +/-   ##
========================================
  Coverage    45.90%   45.90%           
========================================
  Files          521      521           
  Lines        18187    18187           
  Branches      3068     3068           
========================================
  Hits          8348     8348           
  Misses        8974     8974           
  Partials       865      865           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1941324...597fc2b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Built wire-android-staging-compat-pr-4042.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4042.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant